Add perspective video recording via Newton GL viewer for Kitless backends; Fix for Kitfull backends camera position#5011
Conversation
| calls ``_render_kit_perspective_rgb_array`` instead. | ||
| """ | ||
| self._gl_viewer_init_attempted = True | ||
| try: |
There was a problem hiding this comment.
I am still not super sure about the nested try catch here, maybe the first try catch could be somewhat reasonable, but inner case seem better to just fail the program rather than eat it and continue. My personal feeling is that both try catch should just fail immediately, which means user shouldn't be using --video flag at all for their setup.
|
|
||
| Returns a blank frame during warmup or on any error. | ||
| """ | ||
| try: |
There was a problem hiding this comment.
it seems like the long term solution for this is to move _render_kit_perspective_rgb_array in physx folder. And move _try_init_gl_viewer to newton folder, expose them through CfgClass, then there will be no import issue, and you can just pick the right cfg at runtime and do cfg.classtype(cfg) to construct the rgb array of correct backend.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there