Skip to content

Add perspective video recording via Newton GL viewer for Kitless backends; Fix for Kitfull backends camera position#5011

Draft
bdilinila wants to merge 2 commits intoisaac-sim:developfrom
bdilinila:dev/bdilinila/kitless-perspective-recording
Draft

Add perspective video recording via Newton GL viewer for Kitless backends; Fix for Kitfull backends camera position#5011
bdilinila wants to merge 2 commits intoisaac-sim:developfrom
bdilinila:dev/bdilinila/kitless-perspective-recording

Conversation

@bdilinila
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Mar 13, 2026
calls ``_render_kit_perspective_rgb_array`` instead.
"""
self._gl_viewer_init_attempted = True
try:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not super sure about the nested try catch here, maybe the first try catch could be somewhat reasonable, but inner case seem better to just fail the program rather than eat it and continue. My personal feeling is that both try catch should just fail immediately, which means user shouldn't be using --video flag at all for their setup.


Returns a blank frame during warmup or on any error.
"""
try:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like the long term solution for this is to move _render_kit_perspective_rgb_array in physx folder. And move _try_init_gl_viewer to newton folder, expose them through CfgClass, then there will be no import issue, and you can just pick the right cfg at runtime and do cfg.classtype(cfg) to construct the rgb array of correct backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants