Skip to content

fix(studio): scope timeline context targets#2708

Draft
miguel-heygen wants to merge 1 commit into
codex/studio-timeline-e-marquee-selection-v2from
codex/studio-timeline-e-context-targets-v2
Draft

fix(studio): scope timeline context targets#2708
miguel-heygen wants to merge 1 commit into
codex/studio-timeline-e-marquee-selection-v2from
codex/studio-timeline-e-context-targets-v2

Conversation

@miguel-heygen

@miguel-heygen miguel-heygen commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

What

Scope timeline context-menu mutations to the exact clicked element, animation, property lane, and keyframe.

Why

Selection state can be stale or point at a different clip when a context action runs. Ambiguous fallback can remove or mutate the wrong lane, especially when several animations share one element and percentage.

How

  • Route context actions through the shared resolveTimelineKeyframeTarget owner.
  • Carry explicit animation and lane identity through keyframe, gap, and overlay context paths.
  • Reject stale explicit identities instead of falling back to a different animation.
  • Add regressions for non-selected elements, stale identities, and delete-all lane targeting.

This is E5 of the independent Family E draft Graphite stack, stacked only on E1-E4 and the immutable Family D review baseline.

Test plan

  • Unit tests added/updated
  • Manual testing performed
  • Documentation updated (not applicable)

Validated on the exact Family E tip with 130 focused interaction tests, 3 timeline virtualization tests, the full Studio suite (2,991 passed; 18 todos), Studio typecheck/build, the full workspace build, oxfmt, oxlint, diff hygiene, and file-size/Fallow gates.

miguel-heygen commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant