perf(studio): stabilize virtualized keyframe retiming#2705
Draft
miguel-heygen wants to merge 1 commit into
Draft
perf(studio): stabilize virtualized keyframe retiming#2705miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make keyframe retiming deterministic across virtualized timeline renders.
Why
Pointer previews can outlive the diamond DOM node that started a drag. Without stable gesture identity and cleanup, rejected or interrupted retimes can leak pending state into a later drag or commit the wrong keyframe.
How
This is E2 of the independent Family E draft Graphite stack, stacked only on E1 and the immutable Family D review baseline.
Test plan
Validated on the exact Family E tip with 130 focused interaction tests, 3 timeline virtualization tests, the full Studio suite (2,991 passed; 18 todos), Studio typecheck/build, the full workspace build, oxfmt, oxlint, diff hygiene, and file-size/Fallow gates.