Fix Azure SQL DB server_id collision (#677)#679
Closed
erikdarlingdata wants to merge 1 commit intodevfrom
Closed
Conversation
GetServerNameForStorage() only used ServerName for hashing, so two Azure SQL DB connections on the same logical server with different databases got the same server_id. Database-scoped DMVs like dm_db_resource_stats then had their data interleaved. Now appends "/DatabaseName" to the storage key when DatabaseName is set, giving each database its own server_id and clean data separation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
Owner
Author
|
Closing in favor of #680 — community contributor landed the same fix with real Azure SQL DB testing. Thanks @tnguyen7s! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #677 — Azure SQL DB connections to different databases on the same logical server shared the same server_id, causing CPU and other database-scoped DMV data to interleave.
GetServerNameForStorage() now appends /DatabaseName when set, so myserver.database.windows.net/Db1 and myserver.database.windows.net/Db2 hash to different server_ids.
Existing data under the old hash becomes orphaned (acceptable — it was mixed/incorrect anyway).
Test plan