Fix CPU metrics mixed for different Azure SQL databases on same server#680
Merged
erikdarlingdata merged 5 commits intoerikdarlingdata:devfrom Mar 24, 2026
Merged
Conversation
v2.2.0: Fix SignPath signing
Release v2.3.0
Release v2.4.0
Release v2.4.1
GetServerNameForStorage() used only the server hostname to generate storage keys, so multiple Azure SQL databases on the same logical server (e.g. myserver.database.windows.net) produced identical server_ids and their metrics were conflated. Include DatabaseName in the storage key when set, following the existing pattern used for ReadOnlyIntent connections. Fixes erikdarlingdata#677 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Great fix and thorough testing! We had independently landed on the same approach on our side (#679). One minor suggestion — would you mind switching the separator from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetServerNameForStorage()used only the server hostname to generate storage keys, so multiple Azure SQL databases on the same logical server produced identicalserver_ids and their metrics were conflatedDatabaseNamein the storage key when set, following the existing pattern used for:RO(ReadOnlyIntent) connectionsFixes #677
Test plan