Skip to content

Fix Azure SQL DB server_id collision (#677) #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikdarlingdata wants to merge 1 commit into from
Closed

Fix Azure SQL DB server_id collision (#677) #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Lite/Services/RemoteCollectorService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,12 +682,22 @@ protected static long GenerateCollectionId()

/// <summary>
/// Gets the server name used for DuckDB storage and hashing.
/// Appends "/DatabaseName" when set so Azure SQL DB connections to different
/// databases on the same logical server get distinct server_ids (#677).
/// Appends ":RO" for ReadOnlyIntent connections so they get a
/// different server_id than read-write connections to the same host.
/// </summary>
internal static string GetServerNameForStorage(ServerConnection server)
{
return server.ReadOnlyIntent ? server.ServerName + ":RO" : server.ServerName;
var name = server.ServerName;

if (!string.IsNullOrWhiteSpace(server.DatabaseName))
name += "/" + server.DatabaseName;

if (server.ReadOnlyIntent)
name += ":RO";

return name;
}

/// <summary>
Expand Down
Loading