fix(realsense): do not kill the capture loop on a frame timeout - #3622
Draft
jeff-hykin wants to merge 1 commit into
Draft
fix(realsense): do not kill the capture loop on a frame timeout#3622jeff-hykin wants to merge 1 commit into
jeff-hykin wants to merge 1 commit into
Conversation
wait_for_frames raises RuntimeError both when the pipeline is stopped and on a plain frame timeout. The capture loop treated every RuntimeError as shutdown, so one timeout permanently stopped image capture while the IMU callbacks kept running. Retry unless the pipeline was actually stopped.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3622 +/- ##
==========================================
- Coverage 77.26% 77.25% -0.01%
==========================================
Files 1262 1262
Lines 120302 120307 +5
Branches 10600 10601 +1
==========================================
- Hits 92953 92948 -5
- Misses 24284 24295 +11
+ Partials 3065 3064 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait_for_frames raises RuntimeError on frame timeout as well as on pipeline stop. The capture loop exited on any RuntimeError, so one timeout stopped image capture for good while IMU callbacks kept running (seen on Alfred, related to #3449). Now retries unless the pipeline was actually stopped.