Feat/1759 doc codeblocks ci#1884
Conversation
This comment was marked as spam.
This comment was marked as spam.
|
The last commit, 3be2ad5, addresses two previous minor ci run failures: The full ci should be green now and is safe to re-run. If @paul-nechifor insists on "if" change - please say a word. |
|
https://github.com/dimensionalOS/dimos/actions/runs/24695981801/job/72277385519?pr=1884 didn't investigate in detail, approved workflow run, currently fails in some weird way, is this related to it being an external PR? |
What is actually failingThe job name is md-babel but the failure happens before
That installs the project in editable mode which runs setuptools -> build_ext for the pybind11 extensions in setup.py. Pybind11’s auto_cpp_level() compiles a tiny probe (flagcheck.cpp) with c++ and -std=c++17 / 14 / 11. When all of those probes fail it gets:
So this looks as a native C++ build environment problem on the runner not md-babel or markdown execution at all. Two plausible ways to fix it:
The above last commit uses the same ci as in ci.yml. Also updated some docs to have no manipulation imports in CI. |
|
Updated workflow compiles dimos OK. New commit addresses these that erred: b) Marked all replay and asset-dependent session=qb blocks in both quality_filter.md files as skip session=qb (left the two synthetic rx / quality_barrier examples runnable). c) Marked all session=align Python blocks in both temporal_alignment.md files as skip session=align (embedded stays as documentation). |
cd334bf to
addb6c9
Compare
|
md-babel-py is 1.1.4 now, supports --execution-timeout flag which I authored exactly for the purpose: https://github.com/leshy/md-babel-py/releases/tag/v1.1.4. Giving the recent > 60s (md-babe-py default) runs, timeout was increased to 120s. Done in 0707499 On the local machine, the current state of the docs fluctuates between 8 and 33 seconds, and not every block runs. The Golden Rule in codeblocks.md, as stated now, is: "All code blocks must be executable. Never write illustrative/pseudo code blocks. If you're showing an API usage pattern, create a minimal working example that actually runs. This ensures the documentation stays correct as the codebase evolves." However, this might not be possible to achieve. Update in: 30a12a3 Greptile might flag this as Arbitrary code execution from fork PRs on self-hosted runner: github.event_name != 'pull_request' || github.event.pull_request.draft == false. To silence the bot - 0707499 was created, but it will not run on forks. @leshy, this needs your clarification as per #1759. |
d4bb976 to
1655268
Compare
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
| - name: Install Python dependencies | ||
| run: | | ||
| uv sync --all-extras --no-extra dds --no-extra unitree-dds --frozen | ||
| uv pip install matplotlib httpx |
There was a problem hiding this comment.
let's create an issue to figure out why this is missing from our dev image
| - name: Install TurboJPEG and pull Git LFS for doc examples | ||
| run: | | ||
| apt-get update | ||
| DEBIAN_FRONTEND=noninteractive apt-get install -y git-lfs libturbojpeg |
There was a problem hiding this comment.
let's create an issue to figure out why this is missing from our dev image
…increase the timeout to 120sec for slow runs.
.github/workflows/code-cleanup.yml action does, as per @dimensionalOS#1759
The runner is a no-op on Darwin so local work does not require Linux/GPU deps; set RUN_DOC_CODEBLOCKS_FORCE=1 or call md-babel-py directly to run on a Mac. Documented in the script --help. Also: doc-codeblocks workflow sync excludes unitree-dds; fix modules and python-api examples for md-babel (session/skip and runnable fragments).
…for doc examples`
1f28685 to
8db0e17
Compare
|
…openarm_integration.md
Problem
Hi, everyone.
This closes Execute documentation codeblocks in CI #1759 opened by @leshy .
Solution
Two strategies. First introduced the mechanism, workflow and a script. The second - improves present doc codeblocks for: missing imports, modules resolution, some blocks are wrapped to be run-able, those that did not mean to be run are skipped like illustrative one-liners or very heavy blocks, etc. This workflow is disabled for macos. This is a version 1 of the #1759 solution.
Breaking Changes
None
Contributor License Agreement