Conversation
Greptile SummaryAdded Key observations:
Recommendations:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: e9b3f94 |
| # Transport Protocols | ||
| "dimos-lcm", | ||
| "PyTurboJPEG==1.8.2", | ||
| "eclipse-zenoh>=1.7.2", |
There was a problem hiding this comment.
Check that ZenohTransport implementation in dimos/core/transport.py:322 is complete - currently it's just an empty stub (class ZenohTransport(PubSubTransport[T]): ...)
| # Transport Protocols | ||
| "dimos-lcm", | ||
| "PyTurboJPEG==1.8.2", | ||
| "eclipse-zenoh>=1.7.2", |
There was a problem hiding this comment.
Check if docs/usage/transports.md should be updated to document Zenoh transport alongside LCM, SharedMemory, DDS, and ROS transports
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Where are you handling bridge vs host discovery mode? pretty importatnt for zenoh |
This merge request implements Zenoh transport layer, providing a new high-performance pub/sub transport option.
Quick Start
Note
We currently use the python bindings for Eclipse Zenoh as our Zenoh implementation. Its IdlStruct feature lets you define DDS topic types in pure Python, eliminating the need for separate IDL files, with automatic serialization support.
Unit Tests/Benchmarks
This builds off of #1144, which was closed due to having too many merge conflicts with
devand #1036, which was closed because the branch was renamed tomiguel/dds_transport