Skip to content

feat(lister.go): Add opendal_list_options_set_versions and opendal_list_options_set_deleted#7645

Open
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:opendal-7632
Open

feat(lister.go): Add opendal_list_options_set_versions and opendal_list_options_set_deleted#7645
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:opendal-7632

Conversation

@FrankYang0529
Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #7632

Rationale for this change

The Go binding lacked support for listing object versions and delete markers, which are already supported in the Rust core via list_with_versions and list_with_deleted capabilities.

What changes are included in this PR?

  • C binding: Added versions and deleted fields to opendal_list_options, with corresponding setter functions opendal_list_options_set_versions and opendal_list_options_set_deleted.
  • C binding: Added list_with_versions and list_with_deleted fields to opendal_capability and its From<core::Capability> mapping.
  • Go binding: Added ListWithVersions(bool) and ListWithDeleted(bool) functional options, FFI wrappers, and Capability.ListWithVersions() / Capability.ListWithDeleted() methods.

Are there any user-facing changes?

Two new functional options are now available when calling op.List():

  op.List("path/", opendal.ListWithVersions(true))
  op.List("path/", opendal.ListWithDeleted(true))

AI Usage Statement

OpenCode with claude-sonnet-4.6.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 30, 2026
@dentiny
Copy link
Copy Markdown
Member

dentiny commented May 30, 2026

Hey could you please take a look at CI? Ping me anytime, thanks!

@FrankYang0529 FrankYang0529 force-pushed the opendal-7632 branch 3 times, most recently from 18ec42e to ed1741d Compare May 30, 2026 10:06
Comment thread bindings/c/src/metadata.rs Outdated
Comment thread bindings/go/tests/behavior_tests/list_test.go
Comment thread bindings/go/string_ownership_test.go Outdated
…st_options_set_deleted

Signed-off-by: PoAn Yang <payang@apache.org>
@dentiny
Copy link
Copy Markdown
Member

dentiny commented Jun 1, 2026

Hi @FrankYang0529 , do you mind re-requesting review and ping me when ready? Thanks!

@FrankYang0529 FrankYang0529 requested a review from dentiny June 1, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(binding/go): Add ListWithVersions and ListWithDeleted support

2 participants