Skip to content

feat(binding/go): expose all metata fields to golang#7646

Merged
dentiny merged 2 commits into
apache:mainfrom
dentiny:hjiang/expose-metadata-golang
May 30, 2026
Merged

feat(binding/go): expose all metata fields to golang#7646
dentiny merged 2 commits into
apache:mainfrom
dentiny:hjiang/expose-metadata-golang

Conversation

@dentiny
Copy link
Copy Markdown
Member

@dentiny dentiny commented May 30, 2026

Rationale for this change

Language binding implementation should be compatible feature-wise.

What changes are included in this PR?

This PR exposes all metadata fields to C and golang.

Are there any user-facing changes?

No.

AI Usage Statement

GPT-5.5 helped me make the change, opus-4.8 and manual review

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 30, 2026
@dentiny dentiny force-pushed the hjiang/expose-metadata-golang branch from d84a114 to 1943bd3 Compare May 30, 2026 10:27
@dentiny dentiny requested a review from yuchanns May 30, 2026 10:55
@yuchanns
Copy link
Copy Markdown
Member

Can we add some metadata-focused cases in TestBehavior?

FYI:

@dentiny dentiny force-pushed the hjiang/expose-metadata-golang branch from 927666b to 4ff5243 Compare May 30, 2026 12:23
@dentiny
Copy link
Copy Markdown
Member Author

dentiny commented May 30, 2026

Can we add some metadata-focused cases in TestBehavior?

Yeah that makes sense

  • I added some behavior tests for stats
  • We still miss a few APIs on read and write side, for example, write/read with version; I plan to add more tests along the way (e.g., when we add write with version, we use this PR to check version returned).

@FrankYang0529 and I are working together to fill the gaps between go binding and rust core APIs.

Copy link
Copy Markdown
Member

@yuchanns yuchanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 30, 2026
@dentiny
Copy link
Copy Markdown
Member Author

dentiny commented May 30, 2026

I plan to merge this PR now so @FrankYang0529 could be unblocked on #7645.
I will be responsible if any issues.

@dentiny dentiny merged commit 0fe36fd into apache:main May 30, 2026
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants