Skip to content

feat(binding/go): expose all write options#7647

Merged
dentiny merged 14 commits into
apache:mainfrom
dentiny:hjiang/expose-write-options
Jun 1, 2026
Merged

feat(binding/go): expose all write options#7647
dentiny merged 14 commits into
apache:mainfrom
dentiny:hjiang/expose-write-options

Conversation

@dentiny
Copy link
Copy Markdown
Member

@dentiny dentiny commented May 31, 2026

Rationale for this change

golang and C binding should be compatible with rust core functionality-wise.

What changes are included in this PR?

This PR exposes all rust write options to C and go binding, which could be useful together with list and stats operation (for example, #7645).

Are there any user-facing changes?

Yes, new write option is exposed.

AI Usage Statement

GPT-5.5 helped me make the code change, GPT-5.5 and opus-4.8 did the code review.

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 31, 2026
@dentiny
Copy link
Copy Markdown
Member Author

dentiny commented May 31, 2026

CC @FrankYang0529

@dentiny dentiny changed the title Hjiang/expose write options feat(binding/go): expose all write options May 31, 2026
@dentiny dentiny marked this pull request as draft May 31, 2026 00:55
@dentiny dentiny changed the title feat(binding/go): expose all write options [WIP ]feat(binding/go): expose all write options May 31, 2026
@dentiny dentiny force-pushed the hjiang/expose-write-options branch from 2b68507 to 315c9d7 Compare May 31, 2026 01:02
@dentiny dentiny force-pushed the hjiang/expose-write-options branch from 315c9d7 to e76d146 Compare May 31, 2026 01:20
@dentiny dentiny changed the title [WIP ]feat(binding/go): expose all write options feat(binding/go): expose all write options May 31, 2026
@dentiny dentiny marked this pull request as ready for review May 31, 2026 05:59
@dentiny dentiny requested a review from yuchanns June 1, 2026 05:41
Comment thread bindings/go/writer.go Outdated
Comment thread bindings/go/writer.go Outdated
@dentiny dentiny requested a review from yuchanns June 1, 2026 06:25
Copy link
Copy Markdown
Member

@yuchanns yuchanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2026
@dentiny
Copy link
Copy Markdown
Member Author

dentiny commented Jun 1, 2026

Plan to merge this -- @FrankYang0529 and I will followup with delete and read with options.

@dentiny dentiny merged commit 26aba65 into apache:main Jun 1, 2026
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants