Skip to content

chore: Enable U-PR bot - #4138

Merged
EmandM merged 3 commits into
develop-2.0.0from
chore/enable-u-pr
Aug 21, 2026
Merged

chore: Enable U-PR bot#4138
EmandM merged 3 commits into
develop-2.0.0from
chore/enable-u-pr

Conversation

@EmandM

@EmandM EmandM commented Aug 20, 2026

Copy link
Copy Markdown
Member

Purpose of this PR

Enables the U-PR bot to auto-run whenever a PR is opened, and when it is moved out of draft.

Also, swaps the order of some callbacks in the SceneManagementSynchronizationTests due to changes in the CMB service
Related CMB Service work:

Jira ticket

n/a

Changelog

internal change only

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

#4139

Backports

Probably doesn't need a backport.

@EmandM
EmandM requested a review from a team as a code owner August 20, 2026 21:25

@NoelStephensUnity NoelStephensUnity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@EmandM
EmandM enabled auto-merge (squash) August 20, 2026 21:44
@codecov-github-com

codecov-github-com Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-2.0.0    #4138      +/-   ##
=================================================
+ Coverage          73.86%   73.87%   +0.01%     
=================================================
  Files                172      172              
  Lines              28099    28099              
=================================================
+ Hits               20756    20759       +3     
+ Misses              7343     7340       -3     
Flag Coverage Δ
NGOv2_project_testproject_ubuntu_pinnedTrunk 73.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 73.87% <ø> (+0.01%) ⬆️

ℹ️ Need help interpreting these results?

ValidateConnectionEventsAreEqual should check against the expectedEvent.ConnectionEvent.EventType and not the expectedEvent.SceneEvent.SceneEventType (the later throws an exception).
@EmandM
EmandM merged commit 0761334 into develop-2.0.0 Aug 21, 2026
26 checks passed
@EmandM
EmandM deleted the chore/enable-u-pr branch August 21, 2026 02:25
@EmandM EmandM mentioned this pull request Aug 21, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants