Skip to content

chore: Enable U-PR bot [Up Port] - #4139

Merged
NoelStephensUnity merged 3 commits into
develop-3.x.xfrom
chore/enable-u-pr-up-port
Aug 21, 2026
Merged

chore: Enable U-PR bot [Up Port]#4139
NoelStephensUnity merged 3 commits into
develop-3.x.xfrom
chore/enable-u-pr-up-port

Conversation

@NoelStephensUnity

Copy link
Copy Markdown
Member

Up port for #4138

Purpose of this PR

Enables the U-PR bot to auto-run whenever a PR is opened, and when it is moved out of draft.

Also, swaps the order of some callbacks in the SceneManagementSynchronizationTests due to changes in the CMB service
Related CMB Service work:

Jira ticket

n/a

Changelog

internal change only

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

No up-port needed.

Backports

No backport needed.

EmandM and others added 3 commits August 20, 2026 17:46
ValidateConnectionEventsAreEqual should check against the expectedEvent.ConnectionEvent.EventType and not the expectedEvent.SceneEvent.SceneEventType (the later throws an exception).
@NoelStephensUnity
NoelStephensUnity requested a review from a team as a code owner August 20, 2026 23:07
@codecov-github-com

codecov-github-com Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-3.x.x    #4139      +/-   ##
=================================================
+ Coverage          78.01%   78.02%   +0.01%     
=================================================
  Files                153      153              
  Lines              26260    26260              
=================================================
+ Hits               20486    20489       +3     
+ Misses              5774     5771       -3     
Flag Coverage Δ
NGOv2_project_testproject_ubuntu_pinnedTrunk 77.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 78.02% <ø> (+0.01%) ⬆️

ℹ️ Need help interpreting these results?

@EmandM EmandM mentioned this pull request Aug 21, 2026
6 tasks
@NoelStephensUnity
NoelStephensUnity enabled auto-merge (squash) August 21, 2026 14:18
@NoelStephensUnity
NoelStephensUnity merged commit 6ec9bac into develop-3.x.x Aug 21, 2026
26 of 27 checks passed
@NoelStephensUnity
NoelStephensUnity deleted the chore/enable-u-pr-up-port branch August 21, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants