feat: Disable PMTUD if using DA - #4126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4126 +/- ##
=================================================
+ Coverage 73.86% 73.95% +0.08%
=================================================
Files 172 172
Lines 28099 28105 +6
=================================================
+ Hits 20756 20785 +29
+ Misses 7343 7320 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
Not sure if this requires a CHANGELOG entry?
I went back and forth on this and opted not to include one since there's no change in behavior until the defaults in UTP change, which they won't until Unity 7. If you think we'd better have an entry I'm happy to add one though. |
|
@EmandM The only CI failure on the PR is a job that also fails on |
|
The CMB service pushed a change that broke one of our tests. The test was fixed in #4138. |
2 participants
Purpose of this PR
At some point UTP will start enabling path MTU discovery (PMTUD) by default. When that happens, we don't want it enabled in NGO if using distributed authority since the CMB server doesn't support that part of the UTP protocol.
Jira ticket
N/A
Changelog
None
Documentation
No documentation changes or additions were necessary.
Testing & QA
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
3.X: PR #4127
Backports
N/A