Skip to content

test(freeze): add live smoke test for freeze create/update/delete#1436

Open
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/port-freeze-list-native-rust--40ca436afrom
devs/jd/worktree-rust-port/add-live-smoke-test-freeze-create-update-delete--9a7b270e
Open

test(freeze): add live smoke test for freeze create/update/delete#1436
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/port-freeze-list-native-rust--40ca436afrom
devs/jd/worktree-rust-port/add-live-smoke-test-freeze-create-update-delete--9a7b270e

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 19, 2026

Pin POST + PATCH + POST .../{id}/delete against the real
Mergify API as a single round-trip. The freeze is scheduled far
in the future (2099) so the server treats it as scheduled (no
active-freeze delete reason needed) and the test repo's queue
isn't disturbed. The delete runs from finally so cleanup is
guaranteed even when an assertion in the middle fails.

Uses live_admin_token because scheduled-freeze endpoints sit
under the queue-management family; the CI-scoped token is
rejected with 403. Each run picks a unique func-tests-live- smoke-<ts> reason so concurrent or repeated runs don't fight
over the same row.

The freeze ID is parsed out of the create command's human
output (the same _print_freeze block the Rust port mirrors),
so the regex pins the per-freeze output format across both ends
of the port.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

Depends-On: #1435

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 19, 2026 08:20 Failure
@jd
Copy link
Copy Markdown
Member Author

jd commented May 19, 2026

This pull request is part of a Mergify stack:

# Pull Request Link
1 test(queue): add live smoke test for queue show #1408
2 feat(rust): port queue show to native Rust #1399
3 test(skill): port the skill-references test to Rust #1414
4 test(freeze): add live smoke test for freeze list #1434
5 feat(rust): port freeze list to native Rust #1435
6 test(freeze): add live smoke test for freeze create/update/delete #1436 👈
7 feat(rust): port freeze create/update/delete to native Rust #1437
8 refactor(rust): dedupe emit-helper boilerplate across command crates #1438
9 refactor(rust): share test scaffolding via mergify-test-support crate #1439
10 refactor(core): introduce CommandContext for the queue+freeze prelude #1441
11 refactor(ci): consolidate the CI-env scrubber into a shared testing module #1442
12 refactor: drop stale Phase X.Y doc markers and one inline color branch #1443
13 refactor(tui): share StyledGlyph across queue show/status renderers #1444
14 refactor(queue): drop indexmap, group_by_scope returns a Vec<(K, V)> #1445
15 refactor(ci): swap uuid for getrandom in the GHA heredoc delimiter #1446
16 refactor(config): standardize the workspace on serde_yaml_ng for YAML parsing #1447

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 19, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of Depends-On in the body of the pull request

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by>=2
This rule is failing.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify mergify Bot requested a review from a team May 19, 2026 08:37
@jd jd marked this pull request as ready for review May 19, 2026 08:53
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-freeze-create-update-delete--9a7b270e branch from f77ec67 to 414a70b Compare May 19, 2026 08:56
@jd jd temporarily deployed to func-tests-live May 19, 2026 08:56 — with GitHub Actions Inactive
@jd
Copy link
Copy Markdown
Member Author

jd commented May 19, 2026

Revision history

# Type Changes Reason Date
1 initial f77ec67 2026-05-19 08:56 UTC
2 content f77ec67 → 414a70b (raw) 2026-05-19 08:56 UTC
3 rebase 414a70b → 8106d1c (rebase only) 2026-05-19 13:04 UTC
4 rebase 8106d1c → fa07747 (rebase only) 2026-05-19 14:15 UTC

Pin `POST` + `PATCH` + `POST .../{id}/delete` against the real
Mergify API as a single round-trip. The freeze is scheduled far
in the future (2099) so the server treats it as `scheduled` (no
active-freeze delete reason needed) and the test repo's queue
isn't disturbed. The delete runs from `finally` so cleanup is
guaranteed even when an assertion in the middle fails.

Uses `live_admin_token` because scheduled-freeze endpoints sit
under the queue-management family; the CI-scoped token is
rejected with 403. Each run picks a unique `func-tests-live-
smoke-<ts>` reason so concurrent or repeated runs don't fight
over the same row.

The freeze ID is parsed out of the create command's human
output (the same `_print_freeze` block the Rust port mirrors),
so the regex pins the per-freeze output format across both ends
of the port.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change-Id: I9a7b270e04b86ca1bf71985b92350bee29d26f80
@jd jd force-pushed the devs/jd/worktree-rust-port/port-freeze-list-native-rust--40ca436a branch from 078f0e6 to fca204c Compare May 19, 2026 14:14
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-freeze-create-update-delete--9a7b270e branch from 8106d1c to fa07747 Compare May 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant