Skip to content

test(queue): add live smoke test for queue show#1408

Open
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8from
devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba
Open

test(queue): add live smoke test for queue show#1408
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8from
devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 11, 2026

Pins the contract for mergify queue show 404 handling
before the Rust port lands on top. Same test exercises Python
at this PR's CI and Rust on the port commit's rebase.

Uses a PR number far above the test repo's actual PR count to
force the 404 path. That's robust against the test repo's queue
state (PR #1 may or may not be queued at any given moment) and
exercises the parts that would silently break on URL or schema
drift: endpoint reachability, auth, and 404 → MERGIFY_API_ERROR
exit code (6) mapping with the not in the merge queue message.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Depends-On: #1366

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 12:06 Failure
@jd jd had a problem deploying to func-tests-live May 11, 2026 12:06 — with GitHub Actions Failure
@jd
Copy link
Copy Markdown
Member Author

jd commented May 11, 2026

This pull request is part of a Mergify stack:

# Pull Request Link
1 test(ci): add live smoke test for ci queue-info #1406
2 feat(rust): port ci queue-info to native Rust #1407
3 test(queue): add live smoke test for queue status #1409
4 feat(rust): port queue status to native Rust #1359
5 test: derive native queue commands from the binary, not a hardcoded list #1366
6 test(queue): add live smoke test for queue show #1408 👈
7 feat(rust): port queue show to native Rust #1399
8 test(skill): port the skill-references test to Rust #1414

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 11, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of Depends-On in the body of the pull request

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by>=2
This rule is failing.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from 80f3f59 to 4ceec24 Compare May 11, 2026 12:19
@jd jd had a problem deploying to func-tests-live May 11, 2026 12:19 — with GitHub Actions Failure
@jd
Copy link
Copy Markdown
Member Author

jd commented May 11, 2026

Revision history

# Type Changes Reason Date
1 initial 80f3f59 2026-05-11 12:19 UTC
2 rebase 80f3f59 → 4ceec24 2026-05-11 12:19 UTC
3 rebase 4ceec24 → 9712abd 2026-05-11 14:08 UTC
4 content 9712abd → ca322fe 2026-05-11 14:59 UTC
5 content ca322fe → bea6443 2026-05-11 15:05 UTC
6 rebase bea6443 → 2d08ea5 2026-05-11 20:59 UTC
7 rebase 2d08ea5 → 9bbe2bc (rebase only) 2026-05-12 07:44 UTC
8 rebase 9bbe2bc → 85a46d3 (rebase only) 2026-05-13 08:25 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 12:19 Failure
@mergify mergify Bot requested a review from a team May 11, 2026 12:34
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from 4ceec24 to 9712abd Compare May 11, 2026 14:07
@jd jd had a problem deploying to func-tests-live May 11, 2026 14:08 — with GitHub Actions Failure
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 14:08 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 5f46f32 to fe2d5a6 Compare May 11, 2026 14:59
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from 9712abd to ca322fe Compare May 11, 2026 14:59
@jd jd had a problem deploying to func-tests-live May 11, 2026 14:59 — with GitHub Actions Failure
@jd jd had a problem deploying to func-tests-live May 11, 2026 14:59 — with GitHub Actions Failure
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 15:00 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from ca322fe to bea6443 Compare May 11, 2026 15:05
@jd jd temporarily deployed to func-tests-live May 11, 2026 15:05 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 15:06 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 04d5e60 to 8c3dfb2 Compare May 11, 2026 20:59
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from bea6443 to 2d08ea5 Compare May 11, 2026 20:59
@jd jd temporarily deployed to func-tests-live May 11, 2026 20:59 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 11, 2026 20:59 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 20:59 Failure
@jd jd requested a review from Copilot May 12, 2026 07:06
@jd jd marked this pull request as ready for review May 12, 2026 07:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a live functional smoke test to lock in the expected behavior of mergify queue show when the merge-queue pull endpoint returns a 404, ensuring the upcoming Python → Rust port preserves both the user-facing message and exit-code mapping.

Changes:

  • Add a new live smoke test that calls mergify queue show with a very high PR number to force the 404 path.
  • Assert the CLI exits with MERGIFY_API_ERROR (6) and prints “not in the merge queue” (case-insensitive, stdout/stderr combined).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jd jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 8c3dfb2 to c2389e7 Compare May 12, 2026 07:44
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from 2d08ea5 to 9bbe2bc Compare May 12, 2026 07:44
@jd jd temporarily deployed to func-tests-live May 12, 2026 07:44 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 12, 2026 07:44 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 12, 2026 07:45 Failure
Pins the contract for ``mergify queue show`` 404 handling
before the Rust port lands on top. Same test exercises Python
at this PR's CI and Rust on the port commit's rebase.

Uses a PR number far above the test repo's actual PR count to
force the 404 path. That's robust against the test repo's queue
state (PR #1 may or may not be queued at any given moment) and
exercises the parts that would silently break on URL or schema
drift: endpoint reachability, auth, and 404 → ``MERGIFY_API_ERROR``
exit code (6) mapping with the ``not in the merge queue`` message.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Change-Id: I944234ba2d22d99b410f4b8c91e56f0d8a49a9f7
@jd jd force-pushed the devs/jd/worktree-rust-port/add-live-smoke-test-queue-show--944234ba branch from 9bbe2bc to 85a46d3 Compare May 13, 2026 08:25
@jd jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from c2389e7 to 16faa08 Compare May 13, 2026 08:25
@jd jd temporarily deployed to func-tests-live May 13, 2026 08:25 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 13, 2026 08:25 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 13, 2026 08:25 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants