test: derive native queue commands from the binary, not a hardcoded list by jd · Pull Request #1366 · Mergifyio/mergify-cli

jd · 2026-05-05T20:03:18Z

Reviewer feedback (#1352): hardcoding the set of Rust-native queue
subcommands in mergify_cli/tests/queue/test_skill.py made the
skill-reference validation drift-prone — a port PR that forgot to
update NATIVE_QUEUE_COMMANDS would silently pass even though
the skill was referencing a command the binary couldn't handle.

Two changes make the binary the single source of truth:

crates/mergify-cli/src/main.rs factors the
(group, subcommand) pairs into a top-level
NATIVE_COMMANDS const. looks_native iterates that
const instead of a match arm. A new hidden flag
--list-native-commands (intercepted before clap or the
shim) prints one <group> <subcommand> pair per line and
exits 0.
test_skill.py queries the installed mergify binary via
subprocess.run([…, "--list-native-commands"]) to discover
the native set, replacing the NATIVE_QUEUE_COMMANDS
frozenset. The test skips cleanly when the binary isn't on
PATH (rare; uv run pytest installs it first).

The result: the next port PR adds an entry to NATIVE_COMMANDS
in main.rs as part of its normal wiring, and test_skill.py
picks it up automatically. No parallel list to maintain.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Depends-On: #1359

jd · 2026-05-05T20:03:21Z

This pull request is part of a Mergify stack:

#	Pull Request	Link
1	test(ci): add live smoke test for ci queue-info	#1406
2	feat(rust): port ci queue-info to native Rust	#1407
3	test(queue): add live smoke test for queue status	#1409
4	feat(rust): port queue status to native Rust	#1359
5	test: derive native queue commands from the binary, not a hardcoded list	#1366	👈
6	test(queue): add live smoke test for queue show	#1408
7	feat(rust): port queue show to native Rust	#1399
8	test(skill): port the skill-references test to Rust	#1414

mergify · 2026-05-05T20:03:39Z

jd · 2026-05-06T07:25:34Z

Revision history

#	Type	Changes	Date
1	initial	`08a671e`	2026-05-06 07:25 UTC
2	content	`08a671e → 6eea6e2`	2026-05-06 07:25 UTC
3	rebase	`6eea6e2 → c376a33`	2026-05-06 10:57 UTC
4	rebase	`c376a33 → 2ca6999`	2026-05-06 13:00 UTC
5	rebase	`2ca6999 → 41db42a`	2026-05-07 13:40 UTC
6	rebase	`ae15b73 → 4a7622b`	2026-05-07 18:21 UTC
7	rebase	`4a7622b → da5a658`	2026-05-11 07:13 UTC
8	rebase	`da5a658 → 0e20a86`	2026-05-11 11:46 UTC
9	rebase	`0e20a86 → 65e243f`	2026-05-11 12:06 UTC
10	rebase	`65e243f → 2b33674`	2026-05-11 12:19 UTC
11	rebase	`2b33674 → 5f46f32`	2026-05-11 14:08 UTC
12	rebase	`5f46f32 → fe2d5a6`	2026-05-11 14:59 UTC
13	rebase	`fe2d5a6 → 04d5e60`	2026-05-11 15:05 UTC
14	rebase	`04d5e60 → 8c3dfb2`	2026-05-11 20:59 UTC
15	rebase	`8c3dfb2 → c2389e7` (rebase only)	2026-05-12 07:44 UTC
16	rebase	`c2389e7 → 16faa08` (rebase only)	2026-05-13 08:25 UTC

Copilot

Pull request overview

This PR makes the Rust mergify binary the single source of truth for which queue subcommands are handled natively, and updates the skill-reference test to query that information from the installed binary instead of maintaining a parallel hardcoded list.

Changes:

Add a NATIVE_COMMANDS const in crates/mergify-cli/src/main.rs and expose it via a hidden --list-native-commands flag.
Update looks_native to consult NATIVE_COMMANDS rather than a hardcoded match pattern.
Update mergify_cli/tests/queue/test_skill.py to call mergify --list-native-commands to determine native queue commands.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`mergify_cli/tests/queue/test_skill.py`	Replaces hardcoded native queue command list with a subprocess query to the installed `mergify` binary.
`crates/mergify-cli/src/main.rs`	Introduces `NATIVE_COMMANDS` + a hidden listing flag and reuses the const for native-command detection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Reviewer feedback (#1352): hardcoding the set of Rust-native queue subcommands in ``mergify_cli/tests/queue/test_skill.py`` made the skill-reference validation drift-prone — a port PR that forgot to update ``NATIVE_QUEUE_COMMANDS`` would silently pass even though the skill was referencing a command the binary couldn't handle. Two changes make the binary the single source of truth: 1. ``crates/mergify-cli/src/main.rs`` factors the ``(group, subcommand)`` pairs into a top-level ``NATIVE_COMMANDS`` const. ``looks_native`` iterates that const instead of a `match` arm. A new hidden flag ``--list-native-commands`` (intercepted before clap or the shim) prints one ``<group> <subcommand>`` pair per line and exits ``0``. 2. ``test_skill.py`` queries the installed ``mergify`` binary via ``subprocess.run([…, "--list-native-commands"])`` to discover the native set, replacing the ``NATIVE_QUEUE_COMMANDS`` frozenset. The test skips cleanly when the binary isn't on ``PATH`` (rare; ``uv run pytest`` installs it first). The result: the next port PR adds an entry to ``NATIVE_COMMANDS`` in main.rs as part of its normal wiring, and ``test_skill.py`` picks it up automatically. No parallel list to maintain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Change-Id: I74502fe8affcc58f26eaaa9d058668eb36fec83b

This was referenced May 5, 2026

chore(port): drop PORT_STATUS.toml inventory in favor of port-and-delete #1351

Merged

feat(rust): port ci git-refs and ci queue-info to native Rust #1353

Closed

mergify Bot had a problem deploying to Mergify Merge Protections May 5, 2026 20:03 Failure

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 08a671e to 6eea6e2 Compare May 6, 2026 07:25

mergify Bot had a problem deploying to Mergify Merge Protections May 6, 2026 07:25 Failure

mergify Bot requested a review from a team May 6, 2026 07:35

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 6eea6e2 to c376a33 Compare May 6, 2026 10:57

jd force-pushed the devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32 branch from e7ad85a to 4be1b66 Compare May 6, 2026 10:57

jd temporarily deployed to func-tests-live May 6, 2026 10:57 — with GitHub Actions Inactive

mergify Bot had a problem deploying to Mergify Merge Protections May 6, 2026 10:57 Failure

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from c376a33 to 2ca6999 Compare May 6, 2026 13:00

jd force-pushed the devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32 branch from 4be1b66 to d75104b Compare May 6, 2026 13:00

jd mentioned this pull request May 6, 2026

feat(rust): extract reusable terminal-UI primitives into mergify-tui #1379

Closed

jd temporarily deployed to func-tests-live May 6, 2026 13:00 — with GitHub Actions Inactive

jd mentioned this pull request May 6, 2026

fix(cli): surface clap's --help instead of erroring on native subcommands #1380

Merged

jd temporarily deployed to func-tests-live May 6, 2026 13:00 — with GitHub Actions Inactive

mergify Bot had a problem deploying to Mergify Merge Protections May 6, 2026 13:01 Failure

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 2ca6999 to 41db42a Compare May 7, 2026 13:40

jd temporarily deployed to func-tests-live May 7, 2026 13:40 — with GitHub Actions Inactive

mergify Bot had a problem deploying to Mergify Merge Protections May 7, 2026 13:40 Failure

jd force-pushed the devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32 branch from e7408de to e9b1c70 Compare May 7, 2026 15:17

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 65e243f to 2b33674 Compare May 11, 2026 12:19

jd had a problem deploying to func-tests-live May 11, 2026 12:19 — with GitHub Actions Failure

mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 12:19 Failure

jd force-pushed the devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32 branch from 6080692 to 76f551a Compare May 11, 2026 14:07

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 2b33674 to 5f46f32 Compare May 11, 2026 14:07

jd had a problem deploying to func-tests-live May 11, 2026 14:08 — with GitHub Actions Failure

mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 14:08 Failure

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 5f46f32 to fe2d5a6 Compare May 11, 2026 14:59

jd temporarily deployed to func-tests-live May 11, 2026 14:59 — with GitHub Actions Inactive

mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 15:00 Failure

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from fe2d5a6 to 04d5e60 Compare May 11, 2026 15:05

jd temporarily deployed to func-tests-live May 11, 2026 15:05 — with GitHub Actions Inactive

mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 15:06 Failure

jd force-pushed the devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32 branch from cefce9c to e7ff17e Compare May 11, 2026 20:59

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 04d5e60 to 8c3dfb2 Compare May 11, 2026 20:59

jd temporarily deployed to func-tests-live May 11, 2026 20:59 — with GitHub Actions Inactive

mergify Bot had a problem deploying to Mergify Merge Protections May 11, 2026 20:59 Failure

jd marked this pull request as ready for review May 12, 2026 07:05

jd requested a review from Copilot May 12, 2026 07:06

Copilot started reviewing on behalf of jd May 12, 2026 07:07 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread crates/mergify-cli/src/main.rs

mergify Bot added the review threads unresolved label May 12, 2026

jd force-pushed the devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8 branch from 8c3dfb2 to c2389e7 Compare May 12, 2026 07:44

jd force-pushed the devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32 branch from e7ff17e to b6f9bf8 Compare May 12, 2026 07:44

jd mentioned this pull request May 12, 2026

test(skill): port the skill-references test to Rust #1414

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: derive native queue commands from the binary, not a hardcoded list#1366

test: derive native queue commands from the binary, not a hardcoded list#1366
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/port-queue-status-native-rust-phase-1-7--8cebcd32from
devs/jd/worktree-rust-port/derive-native-queue-cmds-binary-hardcoded-list--74502fe8

jd commented May 5, 2026

Uh oh!

jd commented May 5, 2026 •

edited

Loading

Uh oh!

mergify Bot commented May 5, 2026 •

edited

Loading

Uh oh!

jd commented May 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

jd commented May 5, 2026

Uh oh!

jd commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🔴 ⛓️ Depends-On Requirements

🔴 👀 Review Requirements

🔴 🔎 Reviews

🟢 🤖 Continuous Integration

🟢 Enforce conventional commit

🟢 📕 PR description

Uh oh!

jd commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Revision history

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

jd commented May 5, 2026 •

edited

Loading

mergify Bot commented May 5, 2026 •

edited

Loading

jd commented May 6, 2026 •

edited

Loading