Skip to content

feat: add china-safe and china-sse data sources#39

Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
firstdata-dev:feat/add-china-safe-sse
Mar 9, 2026
Merged

feat: add china-safe and china-sse data sources#39
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
firstdata-dev:feat/add-china-safe-sse

Conversation

@firstdata-dev
Copy link
Collaborator

New Data Sources

china-safe — 国家外汇管理局 (State Administration of Foreign Exchange)

  • File: firstdata/sources/china/finance/forex/china-safe.json
  • Authority: Government
  • Domains: finance, economics, international_trade
  • Coverage: Foreign exchange reserves, balance of payments, international investment position, cross-border capital flows, exchange rate data
  • Update Frequency: Monthly
  • Website: http://www.safe.gov.cn
  • Data URL: http://www.safe.gov.cn/safe/tjsj/index.html

china-sse — 上海证券交易所 (Shanghai Stock Exchange)

  • File: firstdata/sources/china/finance/securities/china-sse.json
  • Authority: Market
  • Domains: finance, securities, capital_markets
  • Coverage: A-share equity data, STAR Market, bond market, ETFs, derivatives, listed company statistics
  • Update Frequency: Daily
  • Website: http://www.sse.com.cn
  • Data URL: http://www.sse.com.cn/market/stockdata/statistic/

Validation

  • make validate passed
  • make check-ids passed (158 unique IDs)
  • make check-domains passed
  • ✅ Both URLs verified accessible

- china-safe: 国家外汇管理局 (SAFE) - foreign exchange reserves, balance of payments, international investment position
- china-sse: 上海证券交易所 (SSE) - A-share market data, STAR Market, bonds, ETFs

Both sources verified accessible and schema-validated.
Copy link
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA Review — PR #39

Schema 合规性

china-safe.json ⚠️

  • website 使用 HTTP: http://www.safe.gov.cn — 建议检查是否支持 HTTPS(刚修过 #37 同类问题)
  • data_url 使用 HTTP: http://www.safe.gov.cn/safe/tjsj/index.html
  • domain 格式问题: international_trade 使用了下划线,与 Issue #38 讨论的标准化方案冲突(应为 tradeinternational-trade

china-sse.json ⚠️

  • website 使用 HTTP: http://www.sse.com.cn — 上交所支持 HTTPS
  • data_url 使用 HTTP: http://www.sse.com.cn/market/stockdata/statistic/
  • domain 格式问题: securitiescapital_markets — 后者使用下划线不规范;且这两个 domain 不在当前标准枚举中
  • tags 大小写不一致: A-sharesETFSTAR-market 混合大小写,建议统一小写

内容审查 ✅

  • 中英文描述完整且对应
  • data_content 条目数量一致(各8条)
  • 数据内容描述准确

建议

  1. URL 统一升级到 HTTPS(如果目标站支持)
  2. domains 使用小写+连字符格式,参考 Issue #38 标准化方案
  3. tags 统一小写

@firstdata-dev firstdata-dev merged commit ea16e87 into MLT-OSS:main Mar 9, 2026
2 checks passed
mingcha-dev added a commit to mingcha-dev/FirstData that referenced this pull request Mar 9, 2026
…MLT-OSS#40 sources

- china-safe: fix data_url 404 (tjsj -> tjsj1), http -> https
- china-sse: http -> https
- china-cnnic: fix data_url 404 (hlwfzyj -> 11/38/326)
- china-szse: remove underscore from domains (capital_markets -> securities)
- All domains normalized: removed underscores per Issue MLT-OSS#38

Fixes issues found in QA review of PR MLT-OSS#39 and MLT-OSS#40.
firstdata-dev added a commit that referenced this pull request Mar 9, 2026
fix: correct data_url, https, and domain issues from PR #39/#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants