feat: add china-safe and china-sse data sources#39
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 9, 2026
Merged
feat: add china-safe and china-sse data sources#39firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
Conversation
- china-safe: 国家外汇管理局 (SAFE) - foreign exchange reserves, balance of payments, international investment position - china-sse: 上海证券交易所 (SSE) - A-share market data, STAR Market, bonds, ETFs Both sources verified accessible and schema-validated.
mingcha-dev
suggested changes
Mar 8, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #39
Schema 合规性
china-safe.json ⚠️
- website 使用 HTTP:
http://www.safe.gov.cn— 建议检查是否支持 HTTPS(刚修过 #37 同类问题) - data_url 使用 HTTP:
http://www.safe.gov.cn/safe/tjsj/index.html - domain 格式问题:
international_trade使用了下划线,与 Issue #38 讨论的标准化方案冲突(应为trade或international-trade)
china-sse.json ⚠️
- website 使用 HTTP:
http://www.sse.com.cn— 上交所支持 HTTPS - data_url 使用 HTTP:
http://www.sse.com.cn/market/stockdata/statistic/ - domain 格式问题:
securities和capital_markets— 后者使用下划线不规范;且这两个 domain 不在当前标准枚举中 - tags 大小写不一致:
A-shares、ETF、STAR-market混合大小写,建议统一小写
内容审查 ✅
- 中英文描述完整且对应
- data_content 条目数量一致(各8条)
- 数据内容描述准确
建议
- URL 统一升级到 HTTPS(如果目标站支持)
- domains 使用小写+连字符格式,参考 Issue #38 标准化方案
- tags 统一小写
mingcha-dev
added a commit
to mingcha-dev/FirstData
that referenced
this pull request
Mar 9, 2026
…MLT-OSS#40 sources - china-safe: fix data_url 404 (tjsj -> tjsj1), http -> https - china-sse: http -> https - china-cnnic: fix data_url 404 (hlwfzyj -> 11/38/326) - china-szse: remove underscore from domains (capital_markets -> securities) - All domains normalized: removed underscores per Issue MLT-OSS#38 Fixes issues found in QA review of PR MLT-OSS#39 and MLT-OSS#40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Data Sources
china-safe — 国家外汇管理局 (State Administration of Foreign Exchange)
firstdata/sources/china/finance/forex/china-safe.jsonchina-sse — 上海证券交易所 (Shanghai Stock Exchange)
firstdata/sources/china/finance/securities/china-sse.jsonValidation
make validatepassedmake check-idspassed (158 unique IDs)make check-domainspassed