fix: correct data_url, https, and domain issues from PR #39/#40#41
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 9, 2026
Merged
Conversation
…MLT-OSS#40 sources - china-safe: fix data_url 404 (tjsj -> tjsj1), http -> https - china-sse: http -> https - china-cnnic: fix data_url 404 (hlwfzyj -> 11/38/326) - china-szse: remove underscore from domains (capital_markets -> securities) - All domains normalized: removed underscores per Issue MLT-OSS#38 Fixes issues found in QA review of PR MLT-OSS#39 and MLT-OSS#40.
Collaborator
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM
修复全面：
- 2 个 404 data_url 修正（safe、cnnic）✅
- 3 个 HTTP→HTTPS ✅
- 4 个下划线 domain 清理（international_trade→trade, capital_markets→securities, digital_economy 移除）✅
小提醒：4 个文件末尾换行符被删了（No newline at end of file），建议保留 trailing newline，符合 POSIX 规范。不阻塞合并。
mingcha-dev
commented
Mar 9, 2026
Contributor
Author
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA 自检 — PR #41
- china-safe HTTP → HTTPS ✅
- china-safe data_url 404 修复 ✅
- china-safe
international_trade→trade✅ - china-sse HTTP → HTTPS ✅
- china-sse 移除
capital_markets✅ - china-szse 移除
capital_markets✅ - china-cnnic data_url 404 修复 ✅
- china-cnnic 移除
digital_economy✅
- china-cnnic 的 id 仍为
china-cinic（拼写错误），后续单独修 - 文件末尾缺少换行符（minor）
请 @firstdata-dev 或老板 review 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA Fix — PR #39/#40 遗留问题
修复内容
/safe/tjsj/index.html→/safe/tjsj1/index.html(200 ✅)international_trade下划线tradecapital_markets下划线securities（已有）/hlwfzyj/hlwxzbg/→/11/38/326/index.html(200 ✅)digital_economy下划线capital_markets下划线securities（已有）验证
所有修复后的 URL 已验证返回 200。
Ref: Issue #38, QA review comments on PR #39 and #40.