feat: add SZSE (深圳证券交易所) and CNNIC (中国互联网络信息中心) data sources#40
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 9, 2026
Merged
Conversation
- china-szse: Shenzhen Stock Exchange (深圳证券交易所) - ChiNext board (创业板), SME board trading data - Daily market data, listed companies, bonds, ETF, indices - china-cinic: China Internet Network Information Center (中国互联网络信息中心) - Biannual China Internet Development Statistical Report - Internet users, broadband, mobile internet, e-commerce, domain names
mingcha-dev
suggested changes
Mar 9, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #40
china-szse (深交所)
✅ 通过
- HTTPS URL ✅(吸取了 #39 的教训)
- 有 api_url ✅
- 中英文描述完整,data_content 各9条 ✅
- tags 统一小写 ✅
- authority_level: government — 交易所一般用
market更准确(同 #39 的上交所),但不阻塞
⚠️ 需修改
- domain 下划线:
capital_markets→ 应使用连字符或标准枚举值(同 #39 已指出的问题) securities不在标准枚举中,建议用financial-markets
china-cinic (CNNIC)
⚠️ ID 拼写错误
- 文件名为
cnnic.json,但 id 写的是china-cinic(多了个 i),应为china-cnnic
⚠️ 需修改
- domain 下划线:
digital_economy→ 应使用连字符格式 technology和telecommunications不在当前标准枚举中,建议参考 #38 方案- update_frequency: 描述说每年两次,用
irregular不太准确,但 schema 没有semi-annual选项,可以保留
总结
主要问题:
- ID 拼写错误
china-cinic→china-cnnic(P0,必须修) - domain 下划线问题与 #39 一样,建议统一处理
mingcha-dev
added a commit
to mingcha-dev/FirstData
that referenced
this pull request
Mar 9, 2026
…MLT-OSS#40 sources - china-safe: fix data_url 404 (tjsj -> tjsj1), http -> https - china-sse: http -> https - china-cnnic: fix data_url 404 (hlwfzyj -> 11/38/326) - china-szse: remove underscore from domains (capital_markets -> securities) - All domains normalized: removed underscores per Issue MLT-OSS#38 Fixes issues found in QA review of PR MLT-OSS#39 and MLT-OSS#40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new Chinese authoritative data sources:
1. china-szse — Shenzhen Stock Exchange (深圳证券交易所)
firstdata/sources/china/finance/securities/szse.json2. china-cinic — China Internet Network Information Center (中国互联网络信息中心)
firstdata/sources/china/technology/internet/cnnic.jsonValidation
make validate— schema compliantmake check-ids— no duplicate IDs (158 total unique)make check-domains— domain consistency OK