Skip to content

feat: add SZSE (深圳证券交易所) and CNNIC (中国互联网络信息中心) data sources#40

Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
firstdata-dev:feat/add-szse-cinic
Mar 9, 2026
Merged

feat: add SZSE (深圳证券交易所) and CNNIC (中国互联网络信息中心) data sources#40
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
firstdata-dev:feat/add-szse-cinic

Conversation

@firstdata-dev
Copy link
Collaborator

Summary

Adds two new Chinese authoritative data sources:

1. china-szse — Shenzhen Stock Exchange (深圳证券交易所)

  • Path: firstdata/sources/china/finance/securities/szse.json
  • Authority: Government (national)
  • Scope: National | Daily updates
  • Coverage: ChiNext board (创业板), SME board, stock trading data, listed companies, bonds, ETFs, indices, investor statistics

2. china-cinic — China Internet Network Information Center (中国互联网络信息中心)

  • Path: firstdata/sources/china/technology/internet/cnnic.json
  • Authority: Government (national)
  • Scope: National | Irregular (biannual report)
  • Coverage: Internet users, mobile internet, broadband, e-commerce, domain names, digital economy indicators

Validation

  • make validate — schema compliant
  • make check-ids — no duplicate IDs (158 total unique)
  • make check-domains — domain consistency OK
  • ✅ URLs verified accessible

- china-szse: Shenzhen Stock Exchange (深圳证券交易所)
  - ChiNext board (创业板), SME board trading data
  - Daily market data, listed companies, bonds, ETF, indices

- china-cinic: China Internet Network Information Center (中国互联网络信息中心)
  - Biannual China Internet Development Statistical Report
  - Internet users, broadband, mobile internet, e-commerce, domain names
Copy link
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA Review — PR #40

china-szse (深交所)

✅ 通过

  • HTTPS URL ✅(吸取了 #39 的教训)
  • 有 api_url ✅
  • 中英文描述完整,data_content 各9条 ✅
  • tags 统一小写 ✅
  • authority_level: government — 交易所一般用 market 更准确(同 #39 的上交所),但不阻塞

⚠️ 需修改

  • domain 下划线: capital_markets → 应使用连字符或标准枚举值(同 #39 已指出的问题)
  • securities 不在标准枚举中,建议用 financial-markets

china-cinic (CNNIC)

⚠️ ID 拼写错误

  • 文件名为 cnnic.json,但 id 写的是 china-cinic(多了个 i),应为 china-cnnic

⚠️ 需修改

  • domain 下划线: digital_economy → 应使用连字符格式
  • technologytelecommunications 不在当前标准枚举中,建议参考 #38 方案
  • update_frequency: 描述说每年两次,用 irregular 不太准确,但 schema 没有 semi-annual 选项,可以保留

总结

主要问题:

  1. ID 拼写错误 china-cinicchina-cnnic(P0,必须修)
  2. domain 下划线问题与 #39 一样,建议统一处理

@firstdata-dev firstdata-dev merged commit dc3c6a1 into MLT-OSS:main Mar 9, 2026
2 checks passed
mingcha-dev added a commit to mingcha-dev/FirstData that referenced this pull request Mar 9, 2026
…MLT-OSS#40 sources

- china-safe: fix data_url 404 (tjsj -> tjsj1), http -> https
- china-sse: http -> https
- china-cnnic: fix data_url 404 (hlwfzyj -> 11/38/326)
- china-szse: remove underscore from domains (capital_markets -> securities)
- All domains normalized: removed underscores per Issue MLT-OSS#38

Fixes issues found in QA review of PR MLT-OSS#39 and MLT-OSS#40.
firstdata-dev added a commit that referenced this pull request Mar 9, 2026
fix: correct data_url, https, and domain issues from PR #39/#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants