POC: DOC/Gallery example "Ternary diagram": Migrate frame settings to the new Frame/Axis syntax#4505
Draft
yvonnefroehlich wants to merge 2 commits intomainfrom
Draft
POC: DOC/Gallery example "Ternary diagram": Migrate frame settings to the new Frame/Axis syntax#4505yvonnefroehlich wants to merge 2 commits intomainfrom
yvonnefroehlich wants to merge 2 commits intomainfrom
Conversation
yvonnefroehlich
added
documentation
60 tasks
seisman
reviewed
Apr 7, 2026
| "cafg+lAir component+u %", | ||
| ], | ||
| frame=Frame( | ||
| aaxis=Axis( |
Member
There was a problem hiding this comment.
Hmmm. This one is interesting. I don't want to add aaxis/baxis/caxis to Frame, but what else can do we?
Member
There was a problem hiding this comment.
What about let users still pass xaxis/yaxis/zaxis, and we internally convert them to -Ba/-Bb/-Bc?
yvonnefroehlich
changed the title
yvonnefroehlich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Update the gallery example
basemaps/ternary.pyto use the newly implementedFrameandAxisparameter classes.Need
aaxis,baxis,caxissimilar toxaxis,yaxis,zaxis.Fixes partly #4494
Preview:
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code