Skip to content

POC: DOC/Gallery example "Ternary diagram": Migrate frame settings to the new Frame/Axis syntax #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yvonnefroehlich wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −6
Draft

POC: DOC/Gallery example "Ternary diagram": Migrate frame settings to the new Frame/Axis syntax #4505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce2ef4c
Use new Frame and Axis parameter classes
yvonnefroehlich Apr 7, 2026
8b8d6e6
Fix typo
yvonnefroehlich Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions examples/gallery/basemaps/ternary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# %%
import pygmt
from pygmt.params import Position
from pygmt.params import Axis, Frame, Position

fig = pygmt.Figure()

Expand All @@ -34,11 +34,13 @@
blabel="Water",
clabel="Air",
cmap=True,
frame=[
"aafg+lLimestone component+u %",
"bafg+lWater component+u %",
"cafg+lAir component+u %",
],
frame=Frame(
aaxis=Axis(
Copy link
Copy Markdown
Member

@seisman seisman Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. This one is interesting. I don't want to add aaxis/baxis/caxis to Frame, but what else can do we?

Copy link
Copy Markdown
Member

@seisman seisman Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about let users still pass xaxis/yaxis/zaxis, and we internally convert them to -Ba/-Bb/-Bc?

Copy link
Copy Markdown
Member

@Chuan1937 Chuan1937 Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify：#4517

annot=True, tick=True, grid=True, label="Limestone component", unit="%"
),
baxis=Axis(annot=True, tick=True, grid=True, label="Water component", unit="%"),
caxis=Axis(annot=True, tick=True, grid=True, label="Air component", unit="%"),
),
)

# Add a colorbar indicating the values given in the fourth column of the input dataset
Expand Down
Loading