Figure.ternary: Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc#4517
Open
Figure.ternary: Internally convert xaxis/yaxis/zaxis to -Ba/-Bb/-Bc#4517
Conversation
60 tasks
Member
|
xref: #4505 (comment) |
Member
|
Actually I would split this into two PRs, one for the code changes for the ternary frame itself and one for updating the tests. |
Chuan1937
changed the title
Chuan1937
changed the title
seisman
reviewed
Apr 10, 2026
Member
Actually we have to update the tests in this PR to ensure the code changes are correct. |
seisman
reviewed
Apr 10, 2026
seisman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ternary frame
Update the test
pygmt/tests/test_ternary.pyto use the new implemented Frame and Axis parameter classes.Fixes partly #4494