Skip to content

boundary: add container-based config discovery support#24494

Draft
vitkyrka wants to merge 1 commit into
graphite-base/24494from
boundary-config-discovery
Draft

boundary: add container-based config discovery support#24494
vitkyrka wants to merge 1 commit into
graphite-base/24494from
boundary-config-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to boundary.

Discovery stability log pattern: the container's audit event sink continuously retries writing to the host-owned log file bind-mounted at /var/log/boundary/events.ndjson, which the container's non-root boundary process user can't write to (a pre-existing fixture limitation, unrelated to this change). This produces several differently-worded, benign [ERROR] log lines during every discovery candidate probe, so test_e2e_discovery_all_candidates uses a DISCOVERY_STABILITY_LOG_PATTERNS list that drops the generic error pattern in favor of the more specific crash indicators (panic, fatal, etc.), following the same precedent used for milvus.

Port selection rationale: Port 9203 is Boundary's ops listener, which serves both the /health and /metrics endpoints and is documented as the listener purpose dedicated to health checks and Prometheus metrics.

Motivation

DSCVR-490.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 10, 2026 — with ddtool CLI
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-official

datadog-official Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 100.00% (+11.63%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 37d9a8f | Docs | Datadog PR Page | Give us feedback!

@vitkyrka
vitkyrka changed the base branch from master to graphite-base/24494 July 13, 2026 15:36
vitkyrka added a commit that referenced this pull request Jul 13, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the boundary-config-discovery branch from 7e16b34 to e4b105b Compare July 13, 2026 15:36
@vitkyrka
vitkyrka changed the base branch from graphite-base/24494 to vwhitchurch/docker-run-env-vars-e2e July 13, 2026 15:36

vitkyrka commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vitkyrka
vitkyrka force-pushed the vwhitchurch/docker-run-env-vars-e2e branch from f3908fc to 3251f62 Compare July 14, 2026 09:55
vitkyrka added a commit that referenced this pull request Jul 14, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the boundary-config-discovery branch from df1b43d to fe66319 Compare July 14, 2026 09:56
@vitkyrka
vitkyrka marked this pull request as ready for review July 14, 2026 12:55
@vitkyrka
vitkyrka requested review from a team as code owners July 14, 2026 12:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe66319194

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread boundary/datadog_checks/boundary/config_models/discovery.py
@vitkyrka
vitkyrka force-pushed the boundary-config-discovery branch from fe66319 to 9c74e94 Compare July 14, 2026 14:24
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/docker-run-env-vars-e2e to graphite-base/24494 July 14, 2026 14:28
Adds a from_ports discovery strategy that populates both health_endpoint
and openmetrics_endpoint from the discovered container's port 9203, plus
an auto_conf.yaml ad_identifiers entry matching the hashicorp/boundary
image. Wires get_e2e_discovery_metadata into the E2E fixture, and adds
test_e2e_discovery and test_e2e_discovery_all_candidates.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the graphite-base/24494 branch from 3251f62 to f4762a7 Compare July 14, 2026 14:30
@vitkyrka
vitkyrka force-pushed the boundary-config-discovery branch from 9c74e94 to 37d9a8f Compare July 14, 2026 14:30
@vitkyrka
vitkyrka changed the base branch from graphite-base/24494 to vwhitchurch/docker-run-env-vars-e2e July 14, 2026 14:30
@jeff-morgan-dd jeff-morgan-dd self-assigned this Jul 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@vitkyrka
vitkyrka marked this pull request as draft July 15, 2026 09:58
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/docker-run-env-vars-e2e to graphite-base/24494 July 17, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants