Skip to content

Bump datadog-checks-base floor for integrations with config discovery#24545

Merged
vitkyrka merged 2 commits into
masterfrom
vwhitchurch/discovery-base-version-bump
Jul 15, 2026
Merged

Bump datadog-checks-base floor for integrations with config discovery#24545
vitkyrka merged 2 commits into
masterfrom
vwhitchurch/discovery-base-version-bump

Conversation

@vitkyrka

Copy link
Copy Markdown
Contributor

What does this PR do?

Bumps the minimum allowed datadog-checks-base version from >=37.33.0 to >=37.41.0 in pyproject.toml for the integrations that already ship generated container-based config discovery support: cockroachdb, flink, kong, krakend, milvus, n8n, prefect, pulsar, ray, scylla, teleport, temporal.

Motivation

Each of these integrations' generated config_models/discovery.py imports Service and candidate_ports from datadog_checks.base.utils.discovery, which was only added in datadog-checks-base 37.41.0 (#23963). Their pyproject.toml still allowed datadog-checks-base>=37.33.0, so an environment pinned to an older allowed base version would install a package that advertises discovery support but can't actually load it. Flagged by Codex review on #24494 for boundary; this PR applies the same fix to every integration on master that already merged discovery support.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

…very

These integrations generate a config_models/discovery.py that imports
datadog_checks.base.utils.discovery (Service, candidate_ports), which only
exists starting in datadog-checks-base 37.41.0. Their pyproject.toml still
allowed >=37.33.0, so a user pinned to an older allowed base version would
get a package that advertises discovery support it can't actually load.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 14, 2026 — with ddtool CLI
@datadog-prod-us1-6

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 92.77% (+4.50%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dc92cc3 | Docs | Datadog PR Page | Give us feedback!

@vitkyrka
vitkyrka marked this pull request as ready for review July 14, 2026 14:37
@vitkyrka
vitkyrka requested a review from a team as a code owner July 14, 2026 14:37
@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@vitkyrka
vitkyrka added this pull request to the merge queue Jul 15, 2026
Merged via the queue into master with commit c2f1b6f Jul 15, 2026
80 of 82 checks passed
@vitkyrka
vitkyrka deleted the vwhitchurch/discovery-base-version-bump branch July 15, 2026 06:19
@dd-octo-sts dd-octo-sts Bot added this to the 7.83.0 milestone Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment