Bump datadog-checks-base floor for integrations with config discovery#24545
Merged
Conversation
…very These integrations generate a config_models/discovery.py that imports datadog_checks.base.utils.discovery (Service, candidate_ports), which only exists starting in datadog-checks-base 37.41.0. Their pyproject.toml still allowed >=37.33.0, so a user pinned to an older allowed base version would get a package that advertises discovery support it can't actually load. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: dc92cc3 | Docs | Datadog PR Page | Give us feedback! |
sarah-witt
approved these changes
Jul 14, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps the minimum allowed
datadog-checks-baseversion from>=37.33.0to>=37.41.0inpyproject.tomlfor the integrations that already ship generated container-based config discovery support: cockroachdb, flink, kong, krakend, milvus, n8n, prefect, pulsar, ray, scylla, teleport, temporal.Motivation
Each of these integrations' generated
config_models/discovery.pyimportsServiceandcandidate_portsfromdatadog_checks.base.utils.discovery, which was only added indatadog-checks-base37.41.0 (#23963). Theirpyproject.tomlstill alloweddatadog-checks-base>=37.33.0, so an environment pinned to an older allowed base version would install a package that advertises discovery support but can't actually load it. Flagged by Codex review on #24494 for boundary; this PR applies the same fix to every integration onmasterthat already merged discovery support.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged