gitlab: add container-based config discovery support#24324
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: b92945e | Docs | Datadog PR Page | Give us feedback! |
e791c15 to
f61dc8b
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Lets the Agent auto-discover a gitlab-ce container's OpenMetrics endpoint (port 80, /-/metrics) via the gitlab-ce AD identifier, following the same pattern established for other OpenMetrics integrations (e.g. krakend, teleport).
f61dc8b to
a3df0c7
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3df0c7e6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Validation ReportAll 21 validations passed. Show details
|

What does this PR do?
Adds container-based config discovery support to the gitlab integration.
We only support the OpenMetrics-based check, not the legacy check.
discovery only populates
openmetrics_endpoint, notgitlab_url(which requires the GitLab base URL and can't be inferred from container introspection alone).GitlabCheckV2already guards allgitlab_url-dependent behavior (readiness/liveness checks, version metadata, several tags) behindif self.config.gitlab_url:and logs a debug message otherwise, so the OpenMetrics scrape itself works correctly without it.test_e2e_discoveryonly assertsgitlab.openmetrics.healthand metrics for this reason.Motivation
DSCVR-535
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged