Skip to content

Clarify a Service Worker's scriptURL is used in get/getAll #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 3 commits into from
Jan 15, 2026
Merged

Clarify a Service Worker's scriptURL is used in get/getAll #296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
628e8a8
change SW reg scope to script url
aamuley Jan 6, 2026
d056e75
add aamuley to acks
aamuley Jan 6, 2026
e49d5a7
check for url parsing failure before passing url into url-equals
aamuley Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ typedef sequence<CookieListItem> CookieList;

:: Returns a promise resolving to the first in-scope [=script-visible=] value
for a given cookie name (or other options).
In a service worker context this defaults to the path of the service worker's registered scope.
In a service worker context this defaults to the path of the service worker's [=service worker/script url=].
In a document it defaults to the path of the current document and does not respect changes from {{History/replaceState()}} or {{Document/domain|document.domain}}.
</dl>

Expand Down Expand Up @@ -550,7 +550,7 @@ The <dfn method for=CookieStore>get(|options|)</dfn> method steps are:
1. If |options| [=map/is empty=], then return [=a promise rejected with=] a {{TypeError}}.
1. If |options|["{{CookieStoreGetOptions/url}}"] [=map/exists=]:
1. Let |parsed| be the result of [=basic URL parser|parsing=] |options|["{{CookieStoreGetOptions/url}}"] with |settings|'s [=environment settings object/API base URL=].
1. If [=/this=]'s [=/relevant global object=] is a {{Window}} object and |parsed| does not [=url/equal=] |url| with [=url/equals/exclude fragments=] set to true,
1. If |parsed| is failure or |parsed| does not [=url/equal=] |url| with [=url/equals/exclude fragments=] set to true,
then return [=a promise rejected with=] a {{TypeError}}.
1. If |parsed|'s [=url/origin=] and |url|'s [=url/origin=] are not the [=same origin=],
then return [=a promise rejected with=] a {{TypeError}}.
Expand All @@ -576,7 +576,7 @@ The <dfn method for=CookieStore>get(|options|)</dfn> method steps are:
: |cookies| = await cookieStore . {{CookieStore/getAll(options)|getAll}}(<var ignore>options</var>)

:: Returns a promise resolving to the all in-scope [=script-visible=] value for a given cookie name (or other options).
In a service worker context this defaults to the path of the service worker's registered scope.
In a service worker context this defaults to the path of the service worker's [=service worker/script url=].
In a document it defaults to the path of the current document and does not respect changes from {{History/replaceState()}} or {{Document/domain|document.domain}}.
</dl>

Expand Down Expand Up @@ -607,7 +607,7 @@ The <dfn method for=CookieStore>getAll(|options|)</dfn> method steps are:
1. Let |url| be |settings|'s [=environment/creation URL=].
1. If |options|["{{CookieStoreGetOptions/url}}"] [=map/exists=]:
1. Let |parsed| be the result of [=basic URL parser|parsing=] |options|["{{CookieStoreGetOptions/url}}"] with |settings|'s [=environment settings object/API base URL=].
1. If [=/this=]'s [=/relevant global object=] is a {{Window}} object and |parsed| does not [=url/equal=] |url| with [=url/equals/exclude fragments=] set to true,
1. If |parsed| is failure or |parsed| does not [=url/equal=] |url| with [=url/equals/exclude fragments=] set to true,
then return [=a promise rejected with=] a {{TypeError}}.
1. If |parsed|'s [=url/origin=] and |url|'s [=url/origin=] are not the [=same origin=],
then return [=a promise rejected with=] a {{TypeError}}.
Expand Down Expand Up @@ -1334,6 +1334,7 @@ Alex Russell,
Andrea Marchesini,
Andrew Williams,
Anne van Kesteren,
Anusha Muley,
Ayu Ishii
Ben Kelly,
Craig Francis,
Expand Down