Skip to content

Conversation

@aamuley
Copy link
Collaborator

@aamuley aamuley commented Jan 6, 2026

Changes the note above the get and getAll method steps to from a Service Workers "registration scope" to its script url since that is more well-defined for SWs. Also removes the carveout for Window objects since a SW's API base URL is defined as the script URL as well.
Fixes #247

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@aamuley aamuley marked this pull request as ready for review January 7, 2026 15:24
@DCtheTall
Copy link
Member

DCtheTall commented Jan 7, 2026

Change LGTM, but I think the title of the PR might need rethinking, I think it is sort of misleading/confusing to say the registration's "scope" is its script URL, when scope is already a defined term wrt registrations with a particular meaning (and it is usually not the script URL, since it defaults to script's origin).

@aamuley aamuley changed the title Clarify SW registration scope is its script url Clarify a Service Worker's scriptURL is used in get/getAll Jan 7, 2026
@aamuley
Copy link
Collaborator Author

aamuley commented Jan 7, 2026

ahh yep i see, tried to make that clearer but open to further wording suggestions

@aamuley aamuley requested a review from annevk January 7, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Passing in URL to getAll when called from Service Worker

3 participants