Update code to be compatibile with Rack v3.1+#73
Open
5minpause wants to merge 1 commit intowaterlink:masterfrom
Open
Update code to be compatibile with Rack v3.1+#735minpause wants to merge 1 commit intowaterlink:masterfrom
5minpause wants to merge 1 commit intowaterlink:masterfrom
Conversation
- Removes usage of deprecated class `Rack::Utils::HeaderHash`. - Updates dependencies to be current, e.g. Rack v13.2 - Removes `focus` from tests so all tests run - Fixes and updates all tests
Author
5minpause
changed the title
siebertm
reviewed
Jul 1, 2024
YOU54F
added a commit
to pact-foundation/pact-provider-verifier
that referenced
this pull request
Aug 6, 2024
note using pr fix from unmaintained gem waterlink/rack-reverse-proxy#73
This was referenced Aug 6, 2024
|
Hey @waterlink - friendly ping on this one |
YOU54F
added a commit
to pact-foundation/pact-provider-verifier
that referenced
this pull request
Nov 29, 2024
note using pr fix from unmaintained gem waterlink/rack-reverse-proxy#73
|
@waterlink, another ping. Is this going to be merged soon? |
|
@waterlink yet another ping |
|
@waterlink And yet another ping... this is now bombing all the way to production since it is not guarded upwards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack::Utils::HeaderHash.focusfrom tests so all tests run