Closed
Conversation
- Removes usage of deprecated class `Rack::Utils::HeaderHash`. - Updates dependencies to be current, e.g. Rack v13.2 - Removes `focus` from tests so all tests run - Fixes and updates all tests
Author
|
We will most likely not be maintaining our fork for much longer, as the gem which relies on it will shortly go into deprecation mode. I have published the changes to ruby gems to make it easier to confirm, rather than sourcing from git https://rubygems.org/gems/rack-reverse-proxy-pact Closing off my changes now, ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #73
This PR provides backwards compatibility for Rack 2, preserving the existing behaviour for Rack 2 users, whilst allowing Rack 3 users to still utilise this project.
#73 would fail on earlier versions of Ruby due to the bundler version being updated. We can relax that restriction to allow users on older and newer versions to proceed
Test runs on Ruby 2.7 through to 3.3, with Rack 2 & 3.
One test is failing with Rack 2, as the code stands in master
master...pact-foundation:rack-reverse-proxy:refs/heads/master-ci