add back pane_leaves to sqlite save_app_state which was mistakenly deleted#12672
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR restores deletion of pane_leaves during save_app_state, placing it after the leaf-specific pane tables and before pane_branches/pane_nodes. The deletion order matches the schema relationships, and I did not find correctness, security, or spec-drift issues in the changed line.
Concerns
- This changes user-perceivable app state persistence/restore behavior, but the PR description does not include screenshots or a short screen recording demonstrating the behavior end to end. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
I tried to delete some dead code in #12614 but accidentally deleted something we need. Adding it back.