Skip to content

add back pane_leaves to sqlite save_app_state which was mistakenly deleted#12672

Merged
acarl005 merged 1 commit into
masterfrom
andy/add-back-non-dead-code
Jun 15, 2026
Merged

add back pane_leaves to sqlite save_app_state which was mistakenly deleted#12672
acarl005 merged 1 commit into
masterfrom
andy/add-back-non-dead-code

Conversation

@acarl005

Copy link
Copy Markdown
Contributor

Description

I tried to delete some dead code in #12614 but accidentally deleted something we need. Adding it back.

@acarl005 acarl005 requested a review from johnturcoo June 15, 2026 22:35
@cla-bot cla-bot Bot added the cla-signed label Jun 15, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@acarl005

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@johnturcoo johnturcoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR restores deletion of pane_leaves during save_app_state, placing it after the leaf-specific pane tables and before pane_branches/pane_nodes. The deletion order matches the schema relationships, and I did not find correctness, security, or spec-drift issues in the changed line.

Concerns

  • This changes user-perceivable app state persistence/restore behavior, but the PR description does not include screenshots or a short screen recording demonstrating the behavior end to end. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.

Verdict

Found: 0 critical, 0 important, 1 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@acarl005 acarl005 enabled auto-merge (squash) June 15, 2026 22:40
@acarl005 acarl005 merged commit ec29aef into master Jun 15, 2026
32 checks passed
@acarl005 acarl005 deleted the andy/add-back-non-dead-code branch June 15, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants