remove dead code for WelcomePalette#12614
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR removes the obsolete WelcomePalette/Welcome pane implementation, its feature flag wiring, related project-suggestion search deduplication helpers, and the persistence model/schema support for welcome pane rows. It also adds a migration to drop welcome_panes and remove persisted welcome leaves so old snapshots do not try to restore an unsupported pane kind.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the attached diff. No approved spec context was provided for this dead-code removal.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| diesel::delete(schema::code_review_panes::dsl::code_review_panes).execute(conn)?; | ||
| diesel::delete(schema::ambient_agent_panes::dsl::ambient_agent_panes).execute(conn)?; | ||
| diesel::delete(schema::welcome_panes::dsl::welcome_panes).execute(conn)?; | ||
| diesel::delete(schema::pane_leaves::dsl::pane_leaves).execute(conn)?; |
3 participants
Description
This is dead code now. Just deleting it. Replaced by the new agent view. This was the palette that we tried out as the new "zero state" when a new tab was opened. It showed indexed codebases and recent conversations.
Linked Issue
None, this is dead code removal.