Add valve-detection and valve-subtype-resolver to vortex-cv/mission/tacc/visual_inspection#11
Open
Add valve-detection and valve-subtype-resolver to vortex-cv/mission/tacc/visual_inspection#11
Conversation
…sion/tacc/visual_inspection
Author
jorgenfj
requested changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
3 round of review or something?
Assume we always have depth camera properties and remove unsued code.
Also most of the functions here are very large. Try to split them up, or use helper functions.
This review only applied to valve_pose_estimation. Also rename to package name and folders
mission/tacc/visual_inspection/valve_detection/config/valve_detection_params.yaml
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/ros_utils.cpp
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/ros_utils.cpp
Outdated
Show resolved
Hide resolved
...on/tacc/visual_inspection/valve_detection/include/valve_detection/depth_image_processing.hpp
Outdated
Show resolved
Hide resolved
...on/tacc/visual_inspection/valve_detection/include/valve_detection/depth_image_processing.hpp
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/valve_pose_ros.cpp
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/valve_pose_ros.cpp
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/valve_pose_ros.cpp
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/pose_estimator.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
Subtype resolver looks good |
kluge7
requested changes
Mar 27, 2026
mission/tacc/visual_inspection/valve_detection/config/valve_detection_params.yaml
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/config/valve_detection_params.yaml
Outdated
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/include/valve_detection/types.hpp
Show resolved
Hide resolved
mission/tacc/visual_inspection/valve_detection/src/depth_image_processing.cpp
Outdated
Show resolved
Hide resolved
- Updated PoseEstimator class to improve depth image handling and ray-plane intersection logic. - Renamed methods for clarity, including changing `calculate_letterbox_padding` to `compute_letterbox_transform`. - Enhanced the `compute_pose_from_depth` method to return a structured `DetectionResult` instead of `PoseResult`. - Simplified the handling of bounding boxes and their transformations between color and depth images. - Improved the ValvePoseNode class by restructuring parameter declarations and initialization. - Added robust error handling for TF lookups and improved logging for extrinsic transformations. - Streamlined the synchronization of depth and detection messages, ensuring better performance and clarity in the processing pipeline. - Updated debug visualization features to provide clearer outputs during development.
…ameters and scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.