Skip to content

Add valve-detection and valve-subtype-resolver to vortex-cv/mission/tacc/visual_inspection#11

Open
jenscaa wants to merge 10 commits intomainfrom
feat/valve-detection_valve-subtype-resolver
Open

Add valve-detection and valve-subtype-resolver to vortex-cv/mission/tacc/visual_inspection#11
jenscaa wants to merge 10 commits intomainfrom
feat/valve-detection_valve-subtype-resolver

Conversation

@jenscaa
Copy link
Copy Markdown

@jenscaa jenscaa commented Mar 25, 2026

No description provided.

@jenscaa jenscaa requested a review from jorgenfj March 25, 2026 21:16
@jenscaa jenscaa self-assigned this Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 750 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.42%. Comparing base (cf4e4ea) to head (b8833a3).

Files with missing lines Patch % Lines
..._inspection/valve_detection/src/valve_pose_ros.cpp 0.00% 239 Missing ⚠️
..._inspection/valve_detection/src/pose_estimator.cpp 0.00% 161 Missing ⚠️
..._inspection/valve_detection/src/pcl_extraction.cpp 0.00% 158 Missing ⚠️
...ion/valve_detection/src/depth_image_processing.cpp 0.00% 57 Missing ⚠️
...isual_inspection/valve_detection/src/ros_utils.cpp 0.00% 50 Missing ⚠️
...inspection/valve_detection/src/detection_utils.cpp 0.00% 45 Missing ⚠️
...ve_subtype_resolver/src/valve_subtype_resolver.cpp 0.00% 40 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #11      +/-   ##
========================================
- Coverage   9.58%   6.42%   -3.16%     
========================================
  Files         38      45       +7     
  Lines       1524    2274     +750     
  Branches     317     402      +85     
========================================
  Hits         146     146              
- Misses      1292    2042     +750     
  Partials      86      86              
Flag Coverage Δ
unittests 6.42% <0.00%> (-3.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ve_subtype_resolver/src/valve_subtype_resolver.cpp 0.00% <0.00%> (ø)
...inspection/valve_detection/src/detection_utils.cpp 0.00% <0.00%> (ø)
...isual_inspection/valve_detection/src/ros_utils.cpp 0.00% <0.00%> (ø)
...ion/valve_detection/src/depth_image_processing.cpp 0.00% <0.00%> (ø)
..._inspection/valve_detection/src/pcl_extraction.cpp 0.00% <0.00%> (ø)
..._inspection/valve_detection/src/pose_estimator.cpp 0.00% <0.00%> (ø)
..._inspection/valve_detection/src/valve_pose_ros.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kluge7 kluge7 self-requested a review March 26, 2026 07:57
@jenscaa
Copy link
Copy Markdown
Author

jenscaa commented Mar 26, 2026

Third round of reviews
lead

Copy link
Copy Markdown
Contributor

@jorgenfj jorgenfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 round of review or something?

Assume we always have depth camera properties and remove unsued code.
Also most of the functions here are very large. Try to split them up, or use helper functions.

This review only applied to valve_pose_estimation. Also rename to package name and folders

@jorgenfj
Copy link
Copy Markdown
Contributor

Subtype resolver looks good

Copy link
Copy Markdown

@kluge7 kluge7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

kluge7 added 5 commits March 28, 2026 03:28
- Updated PoseEstimator class to improve depth image handling and ray-plane intersection logic.
- Renamed methods for clarity, including changing `calculate_letterbox_padding` to `compute_letterbox_transform`.
- Enhanced the `compute_pose_from_depth` method to return a structured `DetectionResult` instead of `PoseResult`.
- Simplified the handling of bounding boxes and their transformations between color and depth images.
- Improved the ValvePoseNode class by restructuring parameter declarations and initialization.
- Added robust error handling for TF lookups and improved logging for extrinsic transformations.
- Streamlined the synchronization of depth and detection messages, ensuring better performance and clarity in the processing pipeline.
- Updated debug visualization features to provide clearer outputs during development.
@kluge7 kluge7 requested a review from jorgenfj March 28, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants