feat[gpu]: slice support for dyn dispatch#6862
Merged
Conversation
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Merging this PR will improve performance by 12.36%
Performance Changes
Comparing Footnotes
|
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
robert3005
approved these changes
Mar 10, 2026
Contributor
|
Why adding a new method vs fixing |
Contributor
|
Oh I see, cuda_device_ptr becomes an alias for offset_ptr now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice offsets are either applied during the dyn dispatch build plan construction or in case of bitpacking within the dyn dispatch kernel, as sub-byte offsets can't be expressed by pointer arithmetic on the device ptr.
Calling
output_tile_lenas part of the finalexecute_stageloop has no perf overhead compared todevelop.