Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
185c414 to
0eb716e
Compare
robert3005
approved these changes
Mar 10, 2026
Contributor
Author
|
Github is throwing another one of its tantrums it seems |
Merging this PR will improve performance by 12.36%
Performance Changes
Comparing Footnotes
|
Contributor
|
I think #6862 might already fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously we'd return the pointer to the front of the allocation.
We should be returning the pointer to the beginning of the pointed range, e.g. for sliced allocations like what happens when you try and load the patches out of a CudaFlatLayout.
I encountered this after wasting a lot of time trying to unpack why
patches.indices.buffer_handle()andpatches.values.buffer_handle()were the same pointer.Testing
Added a simple unit test + existing test suite.