-
Notifications
You must be signed in to change notification settings - Fork 245
fix(cli): run upgrade checks in shell background #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
liangmiQwQ
wants to merge
7
commits into
voidzero-dev:main
Choose a base branch
from
liangmiQwQ:liang/codex/fix-shell-upgrade-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
80e7bfa
fix(cli): run upgrade checks in shell background
liangmiQwQ cbb133e
test(cli): cover background upgrade checks
liangmiQwQ 955b6f6
test(cli): snapshot background upgrade notice
liangmiQwQ 4df4e2d
fix(cli): validate upgrade lock by file identity
liangmiQwQ ff9c183
test(cli): scope moved-install check to unix
liangmiQwQ 66dedfb
Merge branch 'main' into liang/codex/fix-shell-upgrade-check
liangmiQwQ 829f9b3
Merge branch 'main' into liang/codex/fix-shell-upgrade-check
fengmk2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
...es/vp_cli_snapshots/tests/cli_snapshots/fixtures/command_upgrade_check/mock-manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "vite-plus/latest": { | ||
| "version": "999.0.0", | ||
| "dist": { | ||
| "tarball": "unused", | ||
| "integrity": "sha512-unused" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...s/fixtures/command_upgrade_check/snapshots/command_upgrade_background_notice.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # command_upgrade_background_notice | ||
|
|
||
| A background check records an available update without contaminating machine output, then the foreground CLI shows the generic notice at most once per prompt interval. | ||
|
|
||
| ## `vp upgrade --background-check` | ||
|
|
||
|
|
||
| ## `vpt grep-file $VP_HOME/cache/upgrade-check.json '"status":"available"'` | ||
|
|
||
|
|
||
| ## `vp env list --json` | ||
|
|
||
| Machine-readable output does not consume the pending notice. | ||
|
|
||
|
|
||
| ## `vp env off` | ||
|
|
||
| The next interactive command displays the cached update notice. | ||
|
|
||
| ``` | ||
| VITE+ - The Unified Toolchain for the Web | ||
|
|
||
| ✓ Node.js management set to system-first. | ||
|
|
||
| All vp commands and shims will now prefer system Node.js, falling back to managed if not found. | ||
|
|
||
| Run `vp env on` to always use Vite+ managed Node.js. | ||
|
|
||
| A new version of vp is available. Run `vp upgrade` to update. | ||
| ``` | ||
|
|
||
| ## `vp env off` | ||
|
|
||
| A subsequent command stays quiet after the notice timestamp is recorded. | ||
|
|
||
| ``` | ||
| VITE+ - The Unified Toolchain for the Web | ||
|
|
||
| Node.js management is already set to system-first. | ||
| All vp commands and shims will prefer system Node.js, falling back to managed if not found. | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.