Skip to content

fix(cli): run upgrade checks in shell background - #2380

Open
liangmiQwQ wants to merge 7 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-shell-upgrade-check
Open

fix(cli): run upgrade checks in shell background#2380
liangmiQwQ wants to merge 7 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-shell-upgrade-check

Conversation

@liangmiQwQ

@liangmiQwQ liangmiQwQ commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Close #2234

The upgrade check currently runs alongside each foreground vp command, but the process still waits up to 500 ms for it before exiting. A slow registry can therefore delay fast commands.

This PR makes foreground commands use the last cached result instead. The shell integration refreshes it in a detached process when a terminal starts, so registry requests no longer block commands.

The notice may now appear on a later command, and it no longer includes version numbers—only that an update is available and vp upgrade can install it.

🤖 Generated with Codex

@netlify

netlify Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 829f9b3
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a79effde35a8f00082c8b2c

@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36c5a6dc9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/env/setup.rs Outdated
Comment thread crates/vp_global_cli/src/upgrade_check.rs Outdated
Comment thread crates/vp_global_cli/src/commands/env/setup.rs
Comment thread crates/vp_global_cli/src/main.rs
Comment thread crates/vp_global_cli/src/main.rs

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb6b0770da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/env/setup.rs Outdated

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6a5d0c65b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/env/setup.rs Outdated

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1330d631c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/env/setup.rs Outdated

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 0aaea9d44d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@liangmiQwQ
liangmiQwQ force-pushed the liang/codex/fix-shell-upgrade-check branch from 0aaea9d to 955b6f6 Compare August 8, 2026 14:14
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review August 8, 2026 14:15
@fengmk2 fengmk2 self-assigned this Aug 10, 2026
@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(cli): upgrade check delays fast commands when registry response is slow

2 participants