Skip to content

feat(cli): delegate multiple global installs to npm #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liangmiQwQ wants to merge 1 commit into from
Closed

feat(cli): delegate multiple global installs to npm #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions crates/vite_global_cli/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,11 +554,11 @@ async fn managed_install(
node: Option<&str>,
force: bool,
) -> Result<ExitStatus, Error> {
for package in packages {
if let Err(e) = crate::commands::env::global_install::install(package, node, force).await {
vite_shared::output::raw_stderr(&format!("Failed to install {package}: {e}"));
return Ok(exit_status(1));
}
if let Err(e) = crate::commands::env::global_install::install_many(packages, node, force).await
{
let package_display = packages.join(", ");
vite_shared::output::raw_stderr(&format!("Failed to install {package_display}: {e}"));
return Ok(exit_status(1));
}
Ok(ExitStatus::default())
}
Expand Down Expand Up @@ -586,11 +586,12 @@ async fn managed_update(packages: &[String]) -> Result<ExitStatus, Error> {
} else {
packages.to_vec()
};
for package in &to_update {
if let Err(e) = crate::commands::env::global_install::install(package, None, false).await {
vite_shared::output::raw_stderr(&format!("Failed to update {package}: {e}"));
return Ok(exit_status(1));
}
if let Err(e) =
crate::commands::env::global_install::install_many(&to_update, None, false).await
{
let package_display = to_update.join(", ");
vite_shared::output::raw_stderr(&format!("Failed to update {package_display}: {e}"));
return Ok(exit_status(1));
}
Ok(ExitStatus::default())
}
Expand Down
Loading
Loading