feat(cli): delegate multiple global installs to npm#1591
Closed
liangmiQwQ wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp install -gpackage specs.vp update -gpackage batches through the same path so npm handles the install work in one process.Why
Multiple global package installs previously resolved Node and spawned
npm install -gonce per package. Delegating the package list to one npm invocation lets npm handle its own parallel download and extraction work while Vite+ performs the managed-store commit afterward.Resolves #1476
Validation
cargo test -p vite_global_cli global_install -- --nocapturegit diff --checkNote:
cargo test -p vite_global_clicurrently aborts intests::unknown_argument_detected_with_pass_as_value_hintwith a stack overflow; the same failure reproduces when running that single test directly.🤖 Generate with Codex