Skip to content

chore: switch corepack and .nvmrc, upgrade to node 20 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisgervang wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: switch corepack and .nvmrc, upgrade to node 20 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6380094
Upgrade to Node 20
claude Feb 28, 2026
fa1933d
Switch from Volta to corepack and .nvmrc
claude Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,18 @@ on:
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18]

steps:
- uses: actions/checkout@v2.1.1
- uses: actions/checkout@v4

- uses: c-hive/gha-yarn-cache@v1

- name: Set up Node ${{ matrix.node-version }}
uses: actions/setup-node@v1
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: '.nvmrc'
cache: 'yarn'

- name: Enable corepack
run: corepack enable yarn
Copy link

@cursor cursor bot Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corepack must be enabled before setup-node caching

High Severity

The corepack enable yarn step runs after actions/setup-node@v4 with cache: 'yarn', but setup-node needs yarn to be available at its execution time to resolve the cache directory. Since package.json now declares "packageManager": "yarn@1.22.19", the setup-node action expects corepack to already be enabled to locate the correct yarn binary for caching. This ordering will cause the CI workflow to fail. The corepack enable step needs to be placed before the setup-node step.

Additional Locations (1)

Fix in Cursor Fix in Web


- name: Bootstrap
run: |
Expand All @@ -34,8 +33,7 @@ jobs:
npm run cover

- name: Coveralls
if: matrix.node-version == 18
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: ${{ github.workspace }}/coverage/lcov.info
path-to-lcov: ${{ github.workspace }}/coverage/lcov.info
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20.18.0
2 changes: 1 addition & 1 deletion modules/dev-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@
"puppeteer": "^22.0.0"
},
"engines": {
"node": ">= 18"
"node": ">= 20"
}
}
2 changes: 1 addition & 1 deletion modules/docusaurus-website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@
"react-dom": "*"
},
"engines": {
"node": ">= 18"
"node": ">= 20"
}
}
2 changes: 1 addition & 1 deletion modules/ts-plugins/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@
"typescript": "^5.2.2"
},
"engines": {
"node": ">= 18"
"node": ">= 20"
}
}
5 changes: 1 addition & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,5 @@
"pre-commit": "pre-commit",
"pre-push": "pre-push",
"dependencies": {},
"volta": {
"node": "18.19.0",
"yarn": "1.22.19"
}
"packageManager": "yarn@1.22.19"
}
Loading