chore: switch corepack and .nvmrc, upgrade to node 20#19
chore: switch corepack and .nvmrc, upgrade to node 20#19chrisgervang wants to merge 2 commits intomasterfrom
Conversation
- Bump Volta pin from 18.19.0 to 20.18.0 - Update engines field from >= 18 to >= 20 in all three modules - Update CI: node-version matrix to [20], checkout@v4, setup-node@v4 with built-in yarn cache (replaces deprecated c-hive/gha-yarn-cache), coverallsapp/github-action@v2 https://claude.ai/code/session_0142Pmpg2JL4V53HGuU7tasX
- Add .nvmrc pinned to 20.18.0 - Replace volta field with "packageManager": "yarn@1.22.19" in package.json - Update CI workflow to read node version from .nvmrc and enable corepack https://claude.ai/code/session_0142Pmpg2JL4V53HGuU7tasX
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| cache: 'yarn' | ||
|
|
||
| - name: Enable corepack | ||
| run: corepack enable yarn |
There was a problem hiding this comment.
Corepack must be enabled before setup-node caching
High Severity
The corepack enable yarn step runs after actions/setup-node@v4 with cache: 'yarn', but setup-node needs yarn to be available at its execution time to resolve the cache directory. Since package.json now declares "packageManager": "yarn@1.22.19", the setup-node action expects corepack to already be enabled to locate the correct yarn binary for caching. This ordering will cause the CI workflow to fail. The corepack enable step needs to be placed before the setup-node step.


Aligns Node version management with deck.gl:
Note
Low Risk
Low risk: this only updates tooling/CI Node and Yarn version management, but it could break local dev or CI if any dependency/tooling isn’t compatible with Node 20.
Overview
Switches the repo to Node 20 and standardizes version management by adding
.nvmrc(20.18.0) and replacingvoltapinning withpackageManager: "yarn@1.22.19".Updates the GitHub Actions test workflow to use
actions/checkout@v4andsetup-node@v4withnode-version-file, enables Yarn via Corepack with built-in caching, and bumps the Coveralls action tov2.Raises the
engines.noderequirement to>= 20across the affected workspace packages.Written by Cursor Bugbot for commit fa1933d. This will update automatically on new commits. Configure here.