Skip to content

chore: switch corepack and .nvmrc, upgrade to node 20#19

Open
chrisgervang wants to merge 2 commits intomasterfrom
claude/node-20-22-upgrade-WKVlO
Open

chore: switch corepack and .nvmrc, upgrade to node 20#19
chrisgervang wants to merge 2 commits intomasterfrom
claude/node-20-22-upgrade-WKVlO

Conversation

@chrisgervang
Copy link
Contributor

@chrisgervang chrisgervang commented Mar 1, 2026

Aligns Node version management with deck.gl:

  • Add .nvmrc pinned to 20.18.0
  • Replace volta field with "packageManager": "yarn@1.22.19" in package.json
  • Update CI workflow to read node version from .nvmrc and enable corepack
  • Remove single-element node version matrix (was just [18])

Note

Low Risk
Low risk: this only updates tooling/CI Node and Yarn version management, but it could break local dev or CI if any dependency/tooling isn’t compatible with Node 20.

Overview
Switches the repo to Node 20 and standardizes version management by adding .nvmrc (20.18.0) and replacing volta pinning with packageManager: "yarn@1.22.19".

Updates the GitHub Actions test workflow to use actions/checkout@v4 and setup-node@v4 with node-version-file, enables Yarn via Corepack with built-in caching, and bumps the Coveralls action to v2.

Raises the engines.node requirement to >= 20 across the affected workspace packages.

Written by Cursor Bugbot for commit fa1933d. This will update automatically on new commits. Configure here.

- Bump Volta pin from 18.19.0 to 20.18.0
- Update engines field from >= 18 to >= 20 in all three modules
- Update CI: node-version matrix to [20], checkout@v4, setup-node@v4
  with built-in yarn cache (replaces deprecated c-hive/gha-yarn-cache),
  coverallsapp/github-action@v2

https://claude.ai/code/session_0142Pmpg2JL4V53HGuU7tasX
- Add .nvmrc pinned to 20.18.0
- Replace volta field with "packageManager": "yarn@1.22.19" in package.json
- Update CI workflow to read node version from .nvmrc and enable corepack

https://claude.ai/code/session_0142Pmpg2JL4V53HGuU7tasX
@chrisgervang chrisgervang changed the title Switch from Volta to corepack and .nvmrc, upgrade to node 20 chore: switch corepack and .nvmrc, upgrade to node 20 Mar 1, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

cache: 'yarn'

- name: Enable corepack
run: corepack enable yarn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corepack must be enabled before setup-node caching

High Severity

The corepack enable yarn step runs after actions/setup-node@v4 with cache: 'yarn', but setup-node needs yarn to be available at its execution time to resolve the cache directory. Since package.json now declares "packageManager": "yarn@1.22.19", the setup-node action expects corepack to already be enabled to locate the correct yarn binary for caching. This ordering will cause the CI workflow to fail. The corepack enable step needs to be placed before the setup-node step.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants