Skip to content

test: fix failing tests Typesense server versions v29.0 and below #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tharropoulos wants to merge 5 commits into
base: master
Choose a base branch
from
Open

test: fix failing tests Typesense server versions v29.0 and below #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24cb4ac
linux only metrics
phanirithvij Mar 25, 2026
ed2f6f3
generated temp path
phanirithvij Mar 25, 2026
9004767
tests fix endpoint path
phanirithvij Mar 25, 2026
f6989c8
tests fix rule_id
phanirithvij Mar 25, 2026
6eecb90
test: gate v30 collection schema expectations
tharropoulos May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/analytics_rules_v1_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_get_missing_analytics_rule(fake_analytics_rules: AnalyticsRulesV1) -> N
"""Test that the AnalyticsRulesV1 object can get a missing analytics_rule."""
analytics_rule = fake_analytics_rules["company_analytics_rule"]

assert analytics_rule.rule_id == "company_analytics_rule"
assert analytics_rule.rule_name == "company_analytics_rule"
assert_match_object(analytics_rule.api_call, fake_analytics_rules.api_call)
assert_object_lists_match(
analytics_rule.api_call.node_manager.nodes,
Expand Down
31 changes: 21 additions & 10 deletions tests/collection_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,24 @@
assert_object_lists_match,
assert_to_contain_object,
)
from tests.utils.version import is_v30_or_above
from typesense.sync.api_call import ApiCall
from typesense.sync.client import Client
from typesense.sync.collection import Collection
from typesense.sync.collections import Collections
from typesense.types.collection import CollectionSchema


is_v30_or_above_server = is_v30_or_above(
Client(
{
"api_key": "xyz",
"nodes": [{"host": "localhost", "port": 8108, "protocol": "http"}],
}
)
)


def test_init(fake_api_call: ApiCall) -> None:
"""Test that the Collection object is initialized correctly."""
collection = Collection(fake_api_call, "companies")
Expand Down Expand Up @@ -52,7 +64,6 @@ def test_actual_retrieve(
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
{
Expand All @@ -66,17 +77,19 @@ def test_actual_retrieve(
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
],
"name": "companies",
"num_documents": 0,
"symbols_to_index": [],
"token_separators": [],
"synonym_sets": [],
"curation_sets": [],
}
if is_v30_or_above_server:
expected["synonym_sets"] = []
expected["curation_sets"] = []
expected["fields"][0]["truncate_len"] = 100
expected["fields"][1]["truncate_len"] = 100

response.pop("created_at")

Expand All @@ -93,10 +106,8 @@ def test_actual_update(
{"fields": [{"name": "num_locations", "type": "int32"}]},
)

expected: CollectionSchema = {
"fields": [
{"name": "num_locations", "truncate_len": 100, "type": "int32"},
],
}
expected_field = {"name": "num_locations", "type": "int32"}
if is_v30_or_above_server:
expected_field["truncate_len"] = 100

assert_to_contain_object(response.get("fields")[0], expected.get("fields")[0])
assert_to_contain_object(response.get("fields")[0], expected_field)
242 changes: 85 additions & 157 deletions tests/collections_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Tests for the Collections class."""


import sys

from typesense.async_.api_call import AsyncApiCall
Expand All @@ -13,11 +12,68 @@

from tests.utils.object_assertions import assert_match_object, assert_object_lists_match
from typesense.sync.api_call import ApiCall
from tests.utils.version import is_v30_or_above
from typesense.sync.collections import Collections
from typesense.async_.collections import AsyncCollections
from typesense.sync.client import Client
from typesense.types.collection import CollectionSchema


IS_V30_OR_ABOVE = is_v30_or_above(
Client(
{
"api_key": "xyz",
"nodes": [{"host": "localhost", "port": 8108, "protocol": "http"}],
}
)
)


def expected_collection_field(
name: str,
type_: str,
*,
sort: bool,
) -> dict[str, typing.Any]:
field: dict[str, typing.Any] = {
"name": name,
"type": type_,
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": sort,
"infix": False,
"stem": False,
"stem_dictionary": "",
"store": True,
}
if IS_V30_OR_ABOVE:
field["truncate_len"] = 100
return field


def expected_collection_schema(
*,
default_sorting_field: str,
fields: typing.List[dict[str, typing.Any]],
name: str,
) -> CollectionSchema:
expected: CollectionSchema = {
"default_sorting_field": default_sorting_field,
"enable_nested_fields": False,
"fields": fields,
"name": name,
"num_documents": 0,
"symbols_to_index": [],
"token_separators": [],
}
if IS_V30_OR_ABOVE:
expected["synonym_sets"] = []
expected["curation_sets"] = []
return expected


def test_init(fake_api_call: ApiCall) -> None:
"""Test that the Collections object is initialized correctly."""
collections = Collections(fake_api_call)
Expand Down Expand Up @@ -98,46 +154,14 @@ def test_get_existing_collection(fake_collections: Collections) -> None:

def test_actual_create(actual_collections: Collections, delete_all: None) -> None:
"""Test that the Collections object can create a collection on Typesense Server."""
expected: CollectionSchema = {
"default_sorting_field": "",
"enable_nested_fields": False,
"fields": [
{
"name": "company_name",
"type": "string",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": False,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
{
"name": "num_employees",
"type": "int32",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": False,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
expected = expected_collection_schema(
default_sorting_field="",
fields=[
expected_collection_field("company_name", "string", sort=False),
expected_collection_field("num_employees", "int32", sort=False),
],
"name": "companies",
"num_documents": 0,
"symbols_to_index": [],
"token_separators": [],
"synonym_sets": [],
"curation_sets": [],
}
name="companies",
)

response = actual_collections.create(
{
Expand Down Expand Up @@ -170,46 +194,14 @@ def test_actual_retrieve(
response = actual_collections.retrieve()

expected: typing.List[CollectionSchema] = [
{
"default_sorting_field": "num_employees",
"enable_nested_fields": False,
"fields": [
{
"name": "company_name",
"type": "string",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": False,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
{
"name": "num_employees",
"type": "int32",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": True,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
expected_collection_schema(
default_sorting_field="num_employees",
fields=[
expected_collection_field("company_name", "string", sort=False),
expected_collection_field("num_employees", "int32", sort=True),
],
"name": "companies",
"num_documents": 0,
"symbols_to_index": [],
"token_separators": [],
"synonym_sets": [],
"curation_sets": [],
},
name="companies",
),
]

response[0].pop("created_at")
Expand All @@ -235,46 +227,14 @@ async def test_actual_create_async(
actual_async_collections: AsyncCollections, delete_all: None
) -> None:
"""Test that the Collections object can create a collection on Typesense Server."""
expected: CollectionSchema = {
"default_sorting_field": "",
"enable_nested_fields": False,
"fields": [
{
"name": "company_name",
"type": "string",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": False,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
{
"name": "num_employees",
"type": "int32",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": False,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
expected = expected_collection_schema(
default_sorting_field="",
fields=[
expected_collection_field("company_name", "string", sort=False),
expected_collection_field("num_employees", "int32", sort=False),
],
"name": "companies",
"num_documents": 0,
"symbols_to_index": [],
"token_separators": [],
"synonym_sets": [],
"curation_sets": [],
}
name="companies",
)

response = await actual_async_collections.create(
{
Expand Down Expand Up @@ -307,46 +267,14 @@ async def test_actual_retrieve_async(
response = await actual_async_collections.retrieve()

expected: typing.List[CollectionSchema] = [
{
"default_sorting_field": "num_employees",
"enable_nested_fields": False,
"fields": [
{
"name": "company_name",
"type": "string",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": False,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
{
"name": "num_employees",
"type": "int32",
"facet": False,
"index": True,
"optional": False,
"locale": "",
"sort": True,
"infix": False,
"stem": False,
"stem_dictionary": "",
"truncate_len": 100,
"store": True,
},
expected_collection_schema(
default_sorting_field="num_employees",
fields=[
expected_collection_field("company_name", "string", sort=False),
expected_collection_field("num_employees", "int32", sort=True),
],
"name": "companies",
"num_documents": 0,
"symbols_to_index": [],
"token_separators": [],
"synonym_sets": [],
"curation_sets": [],
},
name="companies",
),
]

response[0].pop("created_at")
Expand Down
Loading
Loading