Skip to content

PM-4070 Remove check for customers for completeness #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 1 commit into from
Mar 3, 2026
Merged

PM-4070 Remove check for customers for completeness #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/apps/profiles/src/member-profile/page-layout/ProfilePageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ const ProfilePageLayout: FC<ProfilePageLayoutProps> = (props: ProfilePageLayoutP
const isAdminOrTM = props.authProfile?.roles?.includes(UserRole.administrator)
|| props.authProfile?.roles?.includes(UserRole.talentManager)

const canSeeProfileCompleteness = props.authProfile?.handle === props.profile.handle || isAdminOrTM
const isSelf = props.authProfile?.handle === props.profile.handle

const canSeeProfileCompleteness = isSelf || isAdminOrTM

const [isDownloading, setIsDownloading]: [boolean, Dispatch<SetStateAction<boolean>>]
= useState<boolean>(false)
Expand Down Expand Up @@ -124,8 +126,8 @@ const ProfilePageLayout: FC<ProfilePageLayoutProps> = (props: ProfilePageLayoutP
{canSeeProfileCompleteness && (
<ProfileCompleteness
profile={props.profile}
authProfile={props.authProfile}
isAdminOrTM={isAdminOrTM}
isSelf={isSelf}
/>
)}
<div className={styles.sectionWrap}>
Expand Down
10 changes: 4 additions & 6 deletions src/apps/profiles/src/member-profile/profile-completeness/ProfileCompleteness.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import styles from './ProfileCompleteness.module.scss'

interface ProfileCompletenessProps {
profile: UserProfile
authProfile: UserProfile | undefined
isAdminOrTM?: boolean
isSelf: boolean
}

const ProfileCompleteness: FC<ProfileCompletenessProps> = props => {
Expand All @@ -17,9 +17,7 @@ const ProfileCompleteness: FC<ProfileCompletenessProps> = props => {
const isLoading = completeness.isLoading
const isCompleted = completed === 100

const isCustomer = props.authProfile?.roles.some(r => r.indexOf(' Customer') > -1)

const hideCompletenessMeter = isLoading || isCompleted || isCustomer
const hideCompletenessMeter = isLoading || isCompleted
Copy link
Copy Markdown

@github-actions github-actions Bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The removal of the isCustomer check from the hideCompletenessMeter condition changes the behavior of the component. Ensure that this change aligns with the intended functionality, as it will now display the completeness meter for users previously identified as customers.


useEffect(() => { completeness?.mutate() }, [props.profile])

Expand All @@ -43,7 +41,7 @@ const ProfileCompleteness: FC<ProfileCompletenessProps> = props => {
<div className={styles.wrap}>
<strong>Profile: </strong>
{`${completed}% Complete`}
{!props.isAdminOrTM
{props.isSelf
&& (
<div>
<small>
Expand All @@ -59,7 +57,7 @@ const ProfileCompleteness: FC<ProfileCompletenessProps> = props => {
</small>
</div>
)}
{props.isAdminOrTM
{props.isAdminOrTM && !props.isSelf
Comment thread
himaniraghav3 marked this conversation as resolved.
&& (
<div>
<small>
Expand Down
Loading