PM-4070 Remove check for customers for completeness#1506
Merged
himaniraghav3 merged 1 commit intodevfrom Mar 3, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const isCustomer = props.authProfile?.roles.some(r => r.indexOf(' Customer') > -1) | ||
|
|
||
| const hideCompletenessMeter = isLoading || isCompleted || isCustomer | ||
| const hideCompletenessMeter = isLoading || isCompleted |
There was a problem hiding this comment.
[❗❗ correctness]
The removal of the isCustomer check from the hideCompletenessMeter condition changes the behavior of the component. Ensure that this change aligns with the intended functionality, as it will now display the completeness meter for users previously identified as customers.
src/apps/profiles/src/member-profile/profile-completeness/ProfileCompleteness.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-4070
What's in this PR?