Prevent UniFFI FROST wallet material generation#4020
Merged
mswilkison merged 1 commit intoJun 7, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mswilkison
merged commit baac88e
into
feat/frost-schnorr-migration-scaffold
16 checks passed
mswilkison
added a commit
that referenced
this pull request
Jun 7, 2026
## Summary - Require the tbtc-signer engine for FROST DKG output and stop falling back to the generic UniFFI FROST DKG path - Reject unsupported `frost-uniffi-v2` signer material before signing, group-key extraction, Taproot output-key extraction, and FROST wallet-ID derivation - Remove the UniFFI FROST wrapper adapters/tests while keeping the tbtc-signer ABI smoke coverage and legacy `frost-uniffi-v1` ECDSA compatibility ## Rationale `frost-uniffi-v2` is not a production compatibility format. It cannot produce Taproot-tweaked signatures, so a FROST wallet using it can accept Taproot deposits that are effectively unsweepable. This PR fails closed before new FROST wallet material or BTC deposits can be created on that unsupported path. ## Tests - `go test -tags 'frost_native frost_tbtc_signer cgo' ./pkg/frost/signing` - `KEEP_CORE_FROST_TBTC_SIGNER_ACCEPT_SCAFFOLD_KEY_GROUP=true go test -tags 'frost_native frost_tbtc_signer cgo' ./pkg/tbtc` - `go test -tags 'frost_native frost_tbtc_signer frost_roast_retry cgo' ./pkg/frost/signing` Stacked on #4020.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The private testnet E2E reached Taproot deposit sweep signing with a wallet generated as frost-uniffi-v2. That material cannot produce Taproot-tweaked signatures, so real Taproot deposits would be stuck at sweep signing. The production FROST rollout should only generate tbtc-signer-backed FROST wallet material.
Tests