Skip to content

Remove unsupported UniFFI FROST material path#4021

Merged
mswilkison merged 1 commit into
feat/frost-schnorr-migration-scaffoldfrom
codex/remove-uniffi-frost-material
Jun 7, 2026
Merged

Remove unsupported UniFFI FROST material path#4021
mswilkison merged 1 commit into
feat/frost-schnorr-migration-scaffoldfrom
codex/remove-uniffi-frost-material

Conversation

@mswilkison
Copy link
Copy Markdown
Contributor

Summary

  • Require the tbtc-signer engine for FROST DKG output and stop falling back to the generic UniFFI FROST DKG path
  • Reject unsupported frost-uniffi-v2 signer material before signing, group-key extraction, Taproot output-key extraction, and FROST wallet-ID derivation
  • Remove the UniFFI FROST wrapper adapters/tests while keeping the tbtc-signer ABI smoke coverage and legacy frost-uniffi-v1 ECDSA compatibility

Rationale

frost-uniffi-v2 is not a production compatibility format. It cannot produce Taproot-tweaked signatures, so a FROST wallet using it can accept Taproot deposits that are effectively unsweepable. This PR fails closed before new FROST wallet material or BTC deposits can be created on that unsupported path.

Tests

  • go test -tags 'frost_native frost_tbtc_signer cgo' ./pkg/frost/signing
  • KEEP_CORE_FROST_TBTC_SIGNER_ACCEPT_SCAFFOLD_KEY_GROUP=true go test -tags 'frost_native frost_tbtc_signer cgo' ./pkg/tbtc
  • go test -tags 'frost_native frost_tbtc_signer frost_roast_retry cgo' ./pkg/frost/signing

Stacked on #4020.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 478e1a58-6afa-47a6-a248-791f1f00fdee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-uniffi-frost-material

Comment @coderabbitai help to get the list of available commands and usage tips.

@mswilkison mswilkison force-pushed the codex/remove-uniffi-frost-material branch from 42471cc to 3c44ce7 Compare June 7, 2026 16:27
Base automatically changed from codex/remove-uniffi-frost-dkg to feat/frost-schnorr-migration-scaffold June 7, 2026 16:52
@mswilkison mswilkison merged commit 3990465 into feat/frost-schnorr-migration-scaffold Jun 7, 2026
16 checks passed
@mswilkison mswilkison deleted the codex/remove-uniffi-frost-material branch June 7, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant