Skip to content

Add a few fixes for Mediatek mt8188 and mt8195 platforms #10137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 7 commits into from
Sep 3, 2025
Merged

Add a few fixes for Mediatek mt8188 and mt8195 platforms #10137

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e3f214
platform/mtk: Set AFE unused reg to 0 instead of -1.
andrew-mtk Apr 1, 2025
fa92c53
platform/mtk: Add FS timings for MT818X, MT8195
andrew-mtk May 20, 2025
cacbaad
zephyr: alloc: Limit heap size on MTK platforms
andrew-mtk May 27, 2025
85ab536
drivers/mediatek/afe: Fix DMA buffer alignment for MT818X and MT8195
andrew-mtk May 27, 2025
18f80dc
platform: mtk: Add AFE buffer address translation
andrew-mtk Jun 4, 2025
46e5cd9
zephyr: lib/dma.h: Fix build error in dma-legacy.h
andrew-mtk Jul 22, 2025
46515b0
boards: mtk: Fix "dai_common_copy(): nothing to copy" warning
andrew-mtk Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions zephyr/include/sof/lib/dma.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,11 @@ enum sof_dma_cb_status {
/* Attributes have been ported to Zephyr. This condition is necessary until full support of
* CONFIG_SOF_ZEPHYR_STRICT_HEADERS.
*/
#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS
Copy link
Copy Markdown
Contributor

@andyross andyross Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems confusing. This header shouldn't be included if the SOF drivers are in use, no? I suspect the real bug here is upstream header hygiene, some include or another should probably be guarded.

Copy link
Copy Markdown
Collaborator

@kv2019i kv2019i Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyross This is ok. We've done a flurry of changes to drop XTOS support at start of the SOF 2.14 cycle and commit ee58c00 went too far.

This is still overloaded in sof/lib/dma.h, but we'll need to keep the ifdefs until everybody has moved to native drivers.

struct sof_dma;
#else
struct dma;
#endif

/**
* \brief Element of SG list (as array item).
Expand Down Expand Up @@ -194,7 +198,11 @@ struct dma_plat_data {
uint32_t period_count;
};

#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS
struct sof_dma {
#else
struct dma {
#endif
struct dma_plat_data plat_data;
struct k_spinlock lock; /**< locking mechanism */
int sref; /**< simple ref counter, guarded by lock */
Expand All @@ -206,7 +214,11 @@ struct sof_dma {
};

struct dma_chan_data {
#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS
struct sof_dma *dma;
#else
struct dma *dma;
#endif

uint32_t status;
uint32_t direction;
Expand All @@ -224,14 +236,22 @@ struct dma_chan_data {
};

struct dma_info {
#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS
struct sof_dma *dma_array;
#else
struct dma *dma_array;
#endif
size_t num_dmas;
};

/* generic DMA DSP <-> Host copier */
struct dma_copy {
struct dma_chan_data *chan;
#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS
struct sof_dma *dmac;
#else
struct dma *dmac;
#endif
};

struct audio_stream;
Expand Down