Add a few fixes for Mediatek mt8188 and mt8195 platforms by andrew-mtk · Pull Request #10137 · thesofproject/sof

andrew-mtk · 2025-07-24T22:17:12Z

Added a few fixes to existing Mediatek platforms in preparation to port MT8365 to Zephyr

sofci · 2025-07-24T22:20:35Z

Can one of the admins verify this patch?

reply test this please to run this test once

MTK AFE driver check registers for 0 instead of -1 when not in use. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

Add sampling rate Hz to reg value conversion tables for MT8186, MT8188 and MT8195 Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

MTK platforms are built with CONFIG_SYS_HEAP_SMALL_ONLY. If heap size is greater than 0x7fff chunk units, it throws an assert at boot. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

DMA buffer alignment for MT818X and MT8195 must be set to 0x40 Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

Add AFE buffer address translation between CPU and ADSP for MT818X and MT8195 platforms. AFE buffer is allocated in heap located in ADSP SRAM. SRAM base address is not the same for CPU and ADSP address space. AFE hardware accept buffer base address in CPU address space only. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

Reinstate 'struct dma' data type for platforms compiled with CONFIG_ZEPHYR_NATIVE_DRIVERS undefined. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

Override CONFIG_SYS_CLOCK_TICKS_PER_SEC project default setting so 1 millisecond is exactly represented by an integral number of ticks. This fixes warning: <wrn> dai_comp: comp:1.2 dai_common_copy(): nothing to copy Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

andrew-mtk · 2025-07-25T01:51:48Z

Adding @andyross

lyakh · 2025-07-25T07:43:11Z

test this please

andyross

Notes & nitpicks, but nothing fatal. So nice to see vendor support here!

andyross · 2025-07-25T18:11:35Z

src/platform/mtk/dai.c

 static void cfg_convert(const struct afe_cfg *src, struct mtk_base_memif_data *dst)
 {
-#define REGCVT(R) (((R) > 0) ? ((R) - MTK_AFE_BASE) : -1)
+#define REGCVT(R) (((R) > 0) ? ((R) - MTK_AFE_BASE) : 0)


FWIW: this isn't the AFE driver's struct though, it's the Zephyr-side intermediate. I chose -1 because in a few spots it looked like a zero had valid semantic meaning. But I was doing the port blind.

@andyross , I've tried to avoid AFE refactoring that were crashing with a memory violation exception when reg_ofs_base_msb and reg_ofs_end_msb were set to -1

sof/src/platform/mtk/dai.c

Lines 92 to 94 in 800f6ce

dst->reg_ofs_base_msb = REGCVT(src->base.hi);

dst->reg_ofs_cur_msb = REGCVT(src->cur.hi);

dst->reg_ofs_end_msb = REGCVT(src->end.hi);

sof/src/drivers/mediatek/afe/afe-drv.c

Lines 179 to 183 in 800f6ce

/* set start, end, upper 32 bits */

if (memif->data->reg_ofs_base_msb) {

afe_reg_write(afe, memif->data->reg_ofs_base_msb, phys_buf_addr_upper_32);

afe_reg_write(afe, memif->data->reg_ofs_end_msb, phys_buf_addr_upper_32);

}

andyross · 2025-07-25T18:12:54Z

src/platform/mtk/dai.c

+		{ 176400, 23 },
+		{ 192000,  7 },
+		{ 352800, 24 },
+		{ 384000,  8 },


As these tables grow, it's probably best to migrate them to DTS, or to some better-abstracted representation (like, it looks like most of the divisor values are the same between platforms, but some only have a subset of the available frequencies?)

andyross · 2025-07-25T18:14:42Z

zephyr/lib/alloc.c

 #define heapmem ((uint8_t *)ALIGN_UP((uintptr_t)&_mtk_adsp_sram_end, PLATFORM_DCACHE_ALIGN))
+
+/* Heap size is limited to 0x7fffU chunk units when CONFIG_SYS_HEAP_SMALL_ONLY is set */
+#if defined(CONFIG_SYS_HEAP_SMALL_ONLY)


Honestly not sure why SOF is setting this. It's a code size thing, intended to reduce .text footprint on devices whose RAM heaps will never be beyond 256kb. But SOF is actually a really large Zephyr app. Probably best to just turn it off.

But doing the clamp here just for safety isn't wrong either, and it allows cleaner use of the suffix of the region for non-heap things.

andyross · 2025-07-25T18:15:58Z

src/platform/mtk/dai.c

+#define SRAM_CPU_START 0x10800000
 #elif defined(CONFIG_SOC_SERIES_MT818X)
 #define MTK_AFE_BASE 0x10b10000
+#define SRAM_CPU_START 0x10d00000


Nitpick: maybe "HOST_START" or "AP_START" or "LINUX_START" and not "CPU", which is ambiguous. (Zephyr has "cpus" too).

andyross · 2025-07-25T18:20:40Z

zephyr/include/sof/lib/dma.h

 /* Attributes have been ported to Zephyr. This condition is necessary until full support of
 * CONFIG_SOF_ZEPHYR_STRICT_HEADERS.
 */
+#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS


This one seems confusing. This header shouldn't be included if the SOF drivers are in use, no? I suspect the real bug here is upstream header hygiene, some include or another should probably be guarded.

@andyross This is ok. We've done a flurry of changes to drop XTOS support at start of the SOF 2.14 cycle and commit ee58c00 went too far.

This is still overloaded in sof/lib/dma.h, but we'll need to keep the ifdefs until everybody has moved to native drivers.

kv2019i · 2025-07-28T10:04:02Z

zephyr/include/sof/lib/dma.h

 /* Attributes have been ported to Zephyr. This condition is necessary until full support of
 * CONFIG_SOF_ZEPHYR_STRICT_HEADERS.
 */
+#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS


@andyross This is ok. We've done a flurry of changes to drop XTOS support at start of the SOF 2.14 cycle and commit ee58c00 went too far.

This is still overloaded in sof/lib/dma.h, but we'll need to keep the ifdefs until everybody has moved to native drivers.

kv2019i · 2025-07-29T11:16:34Z

@lrudyX can you check, quickbuild seems to be stuck?

andrew-mtk · 2025-09-03T01:26:29Z

@andyross, is there anything else needs to be done for this MR? I'm planning to submit MR that add support for Genio 350 platform that depend on this.

kv2019i · 2025-09-03T14:05:54Z

Sorry for delay @andrew-mtk , it seems the Intel CI got stuck. Given this is so delayed, let me go and merge.

andrew-mtk requested review from abonislawski, dabekjakub, dbaluta, iuliana-prodan, kv2019i, lbetlej, lgirdwood, lyakh, mmaka1 and plbossart as code owners July 24, 2025 22:17

andrew-mtk added 7 commits July 24, 2025 16:12

platform/mtk: Set AFE unused reg to 0 instead of -1.

2e3f214

MTK AFE driver check registers for 0 instead of -1 when not in use. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

platform/mtk: Add FS timings for MT818X, MT8195

fa92c53

Add sampling rate Hz to reg value conversion tables for MT8186, MT8188 and MT8195 Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

zephyr: alloc: Limit heap size on MTK platforms

cacbaad

MTK platforms are built with CONFIG_SYS_HEAP_SMALL_ONLY. If heap size is greater than 0x7fff chunk units, it throws an assert at boot. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

drivers/mediatek/afe: Fix DMA buffer alignment for MT818X and MT8195

85ab536

DMA buffer alignment for MT818X and MT8195 must be set to 0x40 Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

zephyr: lib/dma.h: Fix build error in dma-legacy.h

46e5cd9

Reinstate 'struct dma' data type for platforms compiled with CONFIG_ZEPHYR_NATIVE_DRIVERS undefined. Signed-off-by: Andrew Perepech <andrew.perepech@mediatek.com>

andrew-mtk force-pushed the mt8188-mt8195-fix branch from 817c3a2 to 46515b0 Compare July 24, 2025 23:15

andyross approved these changes Jul 25, 2025

View reviewed changes

kv2019i approved these changes Jul 28, 2025

View reviewed changes

kv2019i merged commit 5e74544 into thesofproject:main Sep 3, 2025
36 of 43 checks passed

	dst->reg_ofs_base_msb = REGCVT(src->base.hi);
	dst->reg_ofs_cur_msb = REGCVT(src->cur.hi);
	dst->reg_ofs_end_msb = REGCVT(src->end.hi);

	/* set start, end, upper 32 bits */
	if (memif->data->reg_ofs_base_msb) {
	afe_reg_write(afe, memif->data->reg_ofs_base_msb, phys_buf_addr_upper_32);
	afe_reg_write(afe, memif->data->reg_ofs_end_msb, phys_buf_addr_upper_32);
	}

Conversation

andrew-mtk commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sofci commented Jul 24, 2025

Uh oh!

andrew-mtk commented Jul 25, 2025

Uh oh!

lyakh commented Jul 25, 2025

Uh oh!

andyross left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kv2019i commented Jul 29, 2025

Uh oh!

andrew-mtk commented Sep 3, 2025

Uh oh!

kv2019i commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andrew-mtk commented Jul 24, 2025 •

edited

Loading