Add new scripts for creating Docker containers to enable better testing of TFQ builds #952
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing those can hide the problem that these are not available in newer Python versions, giving a false sense of security to a developer.
Changes: * Add support for a verbose flag and a help flag * Use a better way to list the images built by this script
For some reason, the previous approach of apt-installing software-properties-common and then doing `add-apt-repository -y ppa:deadsnakes/ppa` started failing for me locally. I suspect some new security measure on Google dev systems. Switching to an approach of getting the deadsnakes list directly works better.
Collaborator
MichaelBroughton
left a comment
MichaelBroughton
left a comment
There was a problem hiding this comment.
Looks good. Could probably shorten things a bit with all the env vars etc, only major concern is what's happening with the install of python3-pip and the interaction with update-alternatives there.
Comment on lines
+64
to
+67
| RUN apt-get -q update -q && \ | ||
| apt-get install -yq --no-install-recommends make clang g++ zlib1g-dev \ | ||
| python${PYTHON_VERSION} python${PYTHON_VERSION}-dev \ | ||
| python${PYTHON_VERSION}-venv python3-pip python-is-python3 |
Collaborator
There was a problem hiding this comment.
Doesn't python3-pip target the OS default python version. If we are in the process of changing it, I think this could get confused. Might want to instead use a versioned path.
Comment on lines
+36
to
+38
| ENV TZ=UTC | ||
| ENV LANG=C.UTF-8 | ||
| ENV LC_ALL=C.UTF-8 |
Collaborator
There was a problem hiding this comment.
Nit: do we really need these ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new subdirectory
release/docker/that contains aDockerfileand a script to create Docker images. These are useful for testing TensorFlow Quantum builds in more isolated environments with different versions of Python. The setup is not fancy, but it is useful when (e.g.) trying different combinations of dependencies with different Python versions.Running the script
create_docker_images.shin that directory creates a total of eight images, with names likeubuntu22-cp39,ubuntu22-cp310, etc. The images are based on Ubuntu Linux 22.04 and 24.04, with the addition of Python preinstalled and very little else.More information can be found in the README file
release/docker/README.md.